Skip to content

Conversation

@moliholy
Copy link
Collaborator

Closes #679.

This PR fetches the latest version of the template instead of picking up the source code as-is in the main branch.

@moliholy moliholy requested a review from AlexD10S October 17, 2025 11:46
@moliholy moliholy self-assigned this Oct 17, 2025
@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

❌ Patch coverage is 80.43478% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.99%. Comparing base (22943bb) to head (3b8dde1).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/pop-cli/src/commands/new/chain.rs 71.73% 10 Missing and 3 partials ⚠️
crates/pop-common/src/git.rs 89.13% 0 Missing and 5 partials ⚠️
@@            Coverage Diff             @@
##             main     #680      +/-   ##
==========================================
+ Coverage   76.79%   76.99%   +0.20%     
==========================================
  Files         108      108              
  Lines       24280    24592     +312     
  Branches    24280    24592     +312     
==========================================
+ Hits        18646    18935     +289     
+ Misses       3702     3675      -27     
- Partials     1932     1982      +50     
Files with missing lines Coverage Δ
crates/pop-common/src/git.rs 77.58% <89.13%> (+1.40%) ⬆️
crates/pop-cli/src/commands/new/chain.rs 50.47% <71.73%> (+1.61%) ⬆️

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@moliholy moliholy force-pushed the feat/pop-new-latest-release branch from ae290b9 to f0dfc0c Compare October 17, 2025 13:08
@moliholy moliholy force-pushed the feat/pop-new-latest-release branch from f0dfc0c to 3b8dde1 Compare October 17, 2025 13:10
Copy link
Member

@al3mart al3mart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely

Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thanks for the quick fix

@moliholy moliholy merged commit b0a49ff into main Oct 17, 2025
19 checks passed
@moliholy moliholy deleted the feat/pop-new-latest-release branch October 17, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix pop new pointing the base-parachain's main branch

4 participants