Skip to content

feat: upgrade to rust 1.90 #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
moliholy merged 1 commit into from
Oct 15, 2025
Merged

feat: upgrade to rust 1.90 #673

moliholy merged 1 commit into from
Oct 15, 2025

Conversation

@moliholy
Copy link
Collaborator

@moliholy moliholy commented Oct 14, 2025 •
edited
Loading

Closes #674.

This PR upgrades pop-cli to the latest stable rust release -> 1.90.

Most of the changes are related to formatting or clippy issues.

@moliholy moliholy self-assigned this Oct 14, 2025
@moliholy moliholy force-pushed the feat/rust-1.90 branch 2 times, most recently from 6ac02ab to 0dde532 Compare October 14, 2025 18:04
@codecov
Copy link

codecov bot commented Oct 14, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 75.20000% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.66%. Comparing base (ccdc46d) to head (53474ed).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/pop-cli/src/commands/bench/pallet.rs 38.09% 12 Missing and 1 partial ⚠️
crates/pop-cli/src/commands/new/chain.rs 0.00% 5 Missing ⚠️
crates/pop-common/src/sourcing/mod.rs 60.00% 3 Missing and 1 partial ⚠️
crates/pop-cli/src/commands/up/network.rs 0.00% 2 Missing ⚠️
crates/pop-cli/src/commands/up/rollup.rs 83.33% 2 Missing ⚠️
crates/pop-chains/src/up/mod.rs 88.88% 0 Missing and 1 partial ⚠️
crates/pop-chains/src/utils/helpers.rs 0.00% 1 Missing ⚠️
crates/pop-cli/src/commands/build/spec.rs 66.66% 0 Missing and 1 partial ⚠️
crates/pop-common/src/api.rs 83.33% 0 Missing and 1 partial ⚠️
crates/pop-common/src/lib.rs 80.00% 0 Missing and 1 partial ⚠️ 
@@            Coverage Diff             @@
##             main     #673      +/-   ##
==========================================
- Coverage   77.46%   76.66%   -0.80%     
==========================================
  Files         110      108       -2     
  Lines       26008    23370    -2638     
  Branches    26008    23370    -2638     
==========================================
- Hits        20146    17917    -2229     
+ Misses       3824     3582     -242     
+ Partials     2038     1871     -167
Files with missing lines Coverage Δ
crates/pop-chains/src/call/metadata/params.rs 91.08% <100.00%> (+0.52%) ⬆️
crates/pop-cli/src/cli.rs 63.23% <ø> (+0.47%) ⬆️
crates/pop-cli/src/commands/bench/block.rs 42.62% <100.00%> (-0.24%) ⬇️
crates/pop-cli/src/commands/bench/machine.rs 41.93% <100.00%> (-0.32%) ⬇️
crates/pop-cli/src/commands/bench/overhead.rs 43.01% <100.00%> (-0.92%) ⬇️
crates/pop-cli/src/commands/bench/storage.rs 67.00% <100.00%> (-2.57%) ⬇️
...rates/pop-cli/src/commands/test/create_snapshot.rs 69.18% <100.00%> (-2.25%) ⬇️
crates/pop-cli/src/common/binary.rs 72.65% <ø> (-0.88%) ⬇️
crates/pop-cli/src/common/builds.rs 77.71% <ø> (-5.62%) ⬇️
crates/pop-cli/src/common/mod.rs 100.00% <ø> (ø)
... and 15 more

... and 77 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@moliholy moliholy requested a review from AlexD10S October 14, 2025 19:11
@moliholy moliholy marked this pull request as ready for review October 14, 2025 19:12
AlexD10S
AlexD10S approved these changes Oct 15, 2025
View reviewed changes
Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just left a question regarding the derivative dependency for better understanding

@moliholy moliholy merged commit 1a4d270 into main Oct 15, 2025
19 checks passed
@moliholy moliholy deleted the feat/rust-1.90 branch October 15, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexD10S AlexD10S AlexD10S approved these changes

Assignees

@moliholy moliholy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Upgrade pop-cli to the latest Rust version

3 participants

@moliholy @AlexD10S