Skip to content

feat: build the chain with runtime #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
moliholy merged 8 commits into from
Oct 17, 2025
Merged

feat: build the chain with runtime #671

moliholy merged 8 commits into from
Oct 17, 2025

Conversation

@moliholy
Copy link
Collaborator

@moliholy moliholy commented Oct 14, 2025 •
edited
Loading

Closes #672.

This PR:

  • Uses the ChainSpecBuilder to build node-based parachains, as well as runtime-based parachains that work with polkadot-omni-node.
  • Allows to specify the --features flag for features other than runtime-benchmarks and try-runtime.
  • Refactors the logic to use the new find_runtime_dir function throughout the whole project to standarize user interaction.
  • Adds/adapts the corresponding tests.

@moliholy moliholy requested a review from AlexD10S October 14, 2025 09:26
@moliholy moliholy self-assigned this Oct 14, 2025
@codecov
Copy link

codecov bot commented Oct 14, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 77.82910% with 96 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.98%. Comparing base (22943bb) to head (0a1c883).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/pop-cli/src/commands/build/chain.rs 66.66% 3 Missing and 21 partials ⚠️
crates/pop-cli/src/commands/build/mod.rs 88.05% 4 Missing and 15 partials ⚠️
crates/pop-cli/src/common/builds.rs 65.38% 4 Missing and 14 partials ⚠️
crates/pop-cli/src/commands/bench/pallet.rs 54.54% 2 Missing and 8 partials ⚠️
crates/pop-cli/src/commands/build/runtime.rs 78.26% 4 Missing and 1 partial ⚠️
crates/pop-cli/src/common/runtime.rs 84.37% 2 Missing and 3 partials ⚠️
crates/pop-cli/src/commands/build/spec.rs 0.00% 3 Missing ⚠️
...es/pop-cli/src/commands/test/on_runtime_upgrade.rs 81.25% 0 Missing and 3 partials ⚠️
crates/pop-cli/src/common/helpers.rs 75.00% 0 Missing and 3 partials ⚠️
crates/pop-cli/src/commands/test/fast_forward.rs 92.30% 0 Missing and 2 partials ⚠️
... and 3 more 
@@            Coverage Diff             @@
##             main     #671      +/-   ##
==========================================
+ Coverage   76.79%   76.98%   +0.18%     
==========================================
  Files         108      108              
  Lines       24280    24518     +238     
  Branches    24280    24518     +238     
==========================================
+ Hits        18646    18874     +228     
+ Misses       3702     3670      -32     
- Partials     1932     1974      +42
Files with missing lines Coverage Δ
crates/pop-cli/src/commands/call/mod.rs 85.54% <ø> (+1.84%) ⬆️
crates/pop-cli/src/commands/test/execute_block.rs 86.51% <83.33%> (-0.10%) ⬇️
crates/pop-cli/src/common/try_runtime.rs 91.05% <83.33%> (-0.06%) ⬇️
crates/pop-cli/src/commands/test/fast_forward.rs 86.00% <92.30%> (-0.27%) ⬇️
crates/pop-contracts/src/utils/mod.rs 80.95% <50.00%> (-1.02%) ⬇️
crates/pop-cli/src/commands/build/spec.rs 74.44% <0.00%> (+1.24%) ⬆️
...es/pop-cli/src/commands/test/on_runtime_upgrade.rs 90.00% <81.25%> (-0.33%) ⬇️
crates/pop-cli/src/common/helpers.rs 80.95% <75.00%> (-3.26%) ⬇️
crates/pop-cli/src/commands/build/runtime.rs 70.83% <78.26%> (+0.14%) ⬆️
crates/pop-cli/src/common/runtime.rs 74.14% <84.37%> (+2.39%) ⬆️
... and 4 more

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@moliholy moliholy force-pushed the feat/pop-build-runtime branch 2 times, most recently from 528a009 to f8341c5 Compare October 14, 2025 13:59
@moliholy moliholy force-pushed the feat/pop-build-runtime branch 4 times, most recently from ec7eb41 to 3eae1ae Compare October 14, 2025 19:50
@moliholy moliholy force-pushed the feat/pop-build-runtime branch from 98e1446 to 0a1c883 Compare October 16, 2025 15:54
AlexD10S
AlexD10S approved these changes Oct 17, 2025
View reviewed changes
Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!!
Just left a comment with a doubt to be sure, but happy to approve and merge this

@moliholy moliholy merged commit aad8a40 into main Oct 17, 2025
19 checks passed
@moliholy moliholy deleted the feat/pop-build-runtime branch October 17, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexD10S AlexD10S AlexD10S approved these changes

@al3mart al3mart Awaiting requested review from al3mart

@tsenovilla tsenovilla Awaiting requested review from tsenovilla

Assignees

@moliholy moliholy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make pop build compatible with parachains without node

3 participants

@moliholy @AlexD10S