feat: read constants and storage when using `pop call chain` #664

moliholy · 2025-10-08T16:45:21Z

Closes #665.

This PR:

Allows pop call chain to specify not only extrinsics, but also constants and storage.
Polishes how documentation is displayed. No more double or leading spaces.
Adds filtering options to some selections.
Makes the option to query functions, storage and constants the first one in the list, and renames it to "Other" instead of "All". This is done from the assumption that users will want to interact more, and several times in a row, with the new functionality.
Marks as "yes" the option by default to perform more calls, since now this option is way more useful.

Screenshots

… chain

codecov · 2025-10-08T18:22:05Z

Codecov Report

❌ Patch coverage is 78.86109% with 245 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.79%. Comparing base (1a4d270) to head (3640a25).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/pop-cli/src/commands/call/chain.rs	54.14%	110 Missing and 34 partials ⚠️
crates/pop-chains/src/call/metadata/mod.rs	88.33%	53 Missing and 36 partials ⚠️
crates/pop-cli/src/common/chain.rs	77.77%	6 Missing and 2 partials ⚠️
crates/pop-chains/src/call/mod.rs	60.00%	1 Missing and 1 partial ⚠️
crates/pop-chains/src/call/metadata/params.rs	87.50%	1 Missing ⚠️
crates/pop-cli/src/commands/call/contract.rs	91.66%	0 Missing and 1 partial ⚠️

@@            Coverage Diff             @@
##             main     #664      +/-   ##
==========================================
+ Coverage   76.66%   76.79%   +0.12%     
==========================================
  Files         108      108              
  Lines       23370    24280     +910     
  Branches    23370    24280     +910     
==========================================
+ Hits        17917    18646     +729     
- Misses       3582     3702     +120     
- Partials     1871     1932      +61

Files with missing lines	Coverage Δ
crates/pop-chains/src/call/metadata/action.rs	`96.05% <100.00%> (-0.06%)`	⬇️
crates/pop-chains/src/errors.rs	`100.00% <ø> (ø)`
crates/pop-chains/src/lib.rs	`0.00% <ø> (ø)`
crates/pop-cli/src/commands/up/rollup.rs	`69.45% <100.00%> (+0.16%)`	⬆️
crates/pop-common/src/lib.rs	`83.82% <ø> (ø)`
crates/pop-contracts/src/utils/metadata.rs	`89.81% <100.00%> (+0.31%)`	⬆️
crates/pop-chains/src/call/metadata/params.rs	`91.42% <87.50%> (+0.33%)`	⬆️
crates/pop-cli/src/commands/call/contract.rs	`63.74% <91.66%> (ø)`
crates/pop-chains/src/call/mod.rs	`63.06% <60.00%> (+0.06%)`	⬆️
crates/pop-cli/src/common/chain.rs	`84.48% <77.77%> (+4.77%)`	⬆️
... and 2 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

crates/pop-contracts/src/utils/metadata.rs

crates/pop-cli/src/commands/call/chain.rs

…sarily all

AlexD10S

I tried out the issues we talked about yesterday and did some extra testing and everything’s running smoothly! Super cool feature, great work!

al3mart

Still half way through the review, but as I will need to complete this tomorrow I'm leaving a nit for now, but this is pretty cool! :)

crates/pop-cli/src/commands/call/chain.rs

al3mart

On testing the feature and doing some queries I've noted the following:

When I querying a map without providing any key as a parameter I was able to obtain all the values for the map, but the keys were not listed. More concretely the map I was reading was CoreDescriptors.

⚙ pop call chain --pallet CoretimeAssignmentProvider --function CoreDescriptors --url wss://paseo.dotters.network/

I think that if I'm querying all entries of a map without passing any concrete key it would be useful getting the keys as well.

I tried querying, without passing any key as parameter, a storage item that expects a tuple as a key: CoreSchedules. This time I got the following parsing error:

⚙  pop call chain --pallet CoretimeAssignmentProvider --function CoreSchedules --url wss://paseo.dotters.network/
│  
■  Failed to query storage: Error parsing metadata for parameter Failed to fetch storage value: Error encoding storage address: Not enough remaining bytes to decode the storage address/key

I was surprised by the different behaviors even if in both cases the parameters were marked as required.

The feat is pretty awesome! I feel the cases as above might be more edge or complex cases that could potentially need some iterations. But in general I feel that this PR is good to go. I'd be happy to introduce fixes as iterations of this feat as we move ahead and identify things, if at all.
Would hold from approval until @moliholy has a chance to see this.

crates/pop-chains/src/call/metadata/mod.rs

crates/pop-cli/src/commands/call/chain.rs

moliholy · 2025-10-16T08:05:13Z

@al3maal thanks for the feedback! I'll take a look today to see if I can address all that. If it's too cumbersome we can iterate in the future.

al3mart · 2025-10-16T09:03:42Z

I think iterating might make the most sense, @moliholy . But I'll wait until you have had some time to have a look at it :)

moliholy · 2025-10-16T12:35:49Z

@al3mart @AlexD10S the problem pointed out is indeed a corner case. I think we're good to merge for now and we can address this in the future.

al3mart

I'm happy with iterating over the edge cases outside of this PR. Let's go!

moliholy · 2025-10-16T12:45:20Z

@al3mart for reference: this is the conflicting key: https://docs.rs/polkadot-runtime-parachains/22.0.0/src/polkadot_runtime_parachains/assigner_coretime/mod.rs.html#236

al3mart

🚀

moliholy self-assigned this Oct 8, 2025

moliholy force-pushed the feat/chain-call-read branch from 33b7470 to f93566d Compare October 8, 2025 17:18

moliholy added 4 commits October 8, 2025 19:21

feat: parse chain constants from metadata

f7d4e6b

feat(chains): parse storage state

a2902b0

test(chains): add tests for chain constants and state

fe15001

feat(cli): allow querying storage and constants when calling pop call…

74b7377

… chain

moliholy force-pushed the feat/chain-call-read branch from f93566d to 74b7377 Compare October 8, 2025 17:21

moliholy requested review from AlexD10S, al3mart and tsenovilla October 8, 2025 17:22

moliholy marked this pull request as ready for review October 8, 2025 17:22

moliholy added 2 commits October 8, 2025 19:32

test: add tests for the chain call functionality

945387a

test: make integration tests pass

a5fa958

moliholy added 3 commits October 9, 2025 02:03

feat: polish how documentation is displayed

6d32b7a

refactor(cli): make the option to query the whole storage the first one

a3556ed

refactor: auto-enable retrying calls

261c667

moliholy requested a review from Daanvdplas October 9, 2025 00:27

moliholy added 3 commits October 9, 2025 02:43

ci: optimize docs test

386432b

test(chains): increase test coverage

03df838

fix: failing test

292c287

moliholy force-pushed the feat/chain-call-read branch from 1192c67 to 292c287 Compare October 9, 2025 09:04

moliholy added 8 commits October 9, 2025 11:38

test: constant and storage

0ee85a8

doc(chains): improve errors

2088bbc

doc(common): add missing documentation for pop()

de75e88

fix(cli): remove function parser

ad47e8f

fix(chains): FunctionNotFound assertion

b63c6c1

fix: FunctionNotFound assetion

52c6101

ci: run integration tests until the end

bc0abd0

feat(cli): parse endpoints directly as JSON array

23ea1f6

Merge branch 'main' into feat/chain-call-read

7b9210c

AlexD10S reviewed Oct 13, 2025

View reviewed changes

crates/pop-contracts/src/utils/metadata.rs Show resolved Hide resolved

crates/pop-cli/src/commands/call/chain.rs Outdated Show resolved Hide resolved

crates/pop-cli/src/commands/call/chain.rs Show resolved Hide resolved

moliholy added 2 commits October 13, 2025 15:59

feat(chains): lowercase hex string

bccbd5c

fix: default value for types without path

2ed23ea

moliholy force-pushed the feat/chain-call-read branch from da1d282 to 2ed23ea Compare October 13, 2025 14:59

fix: test with uppercase hexadecimals

35711d8

moliholy force-pushed the feat/chain-call-read branch from f26c9a5 to 0d1e0a7 Compare October 13, 2025 17:18

moliholy added 2 commits October 13, 2025 19:27

feat: allow to query multiple storage entries

b0a190d

Merge remote-tracking branch 'origin/main' into feat/chain-call-read

5155ad8

moliholy force-pushed the feat/chain-call-read branch from 0d1e0a7 to 5155ad8 Compare October 13, 2025 17:27

moliholy added 2 commits October 13, 2025 20:51

feat: pretty-print large chain calls

53a9f05

feat: allow to specify some parameters via --args flag, but not neces…

862bb4b

…sarily all

AlexD10S approved these changes Oct 14, 2025

View reviewed changes

al3mart reviewed Oct 14, 2025

View reviewed changes

crates/pop-cli/src/commands/call/chain.rs Outdated Show resolved Hide resolved

moliholy added 2 commits October 14, 2025 19:35

doc: improve documentation for the function parameter

8160b5a

Merge remote-tracking branch 'origin/main' into feat/chain-call-read

9f3a0dc

moliholy force-pushed the feat/chain-call-read branch from 925a142 to 9f3a0dc Compare October 15, 2025 09:06

al3mart reviewed Oct 16, 2025

View reviewed changes

crates/pop-chains/src/call/metadata/mod.rs Outdated Show resolved Hide resolved

crates/pop-cli/src/commands/call/chain.rs Show resolved Hide resolved

al3mart approved these changes Oct 16, 2025

View reviewed changes

fix: docs

4de50c6

moliholy force-pushed the feat/chain-call-read branch from c2a67ba to 4de50c6 Compare October 16, 2025 12:55

AlexD10S approved these changes Oct 16, 2025

View reviewed changes

fix: tests

3640a25

al3mart approved these changes Oct 16, 2025

View reviewed changes

moliholy merged commit 22943bb into main Oct 16, 2025
19 checks passed

moliholy deleted the feat/chain-call-read branch October 16, 2025 14:39

feat: read constants and storage when using pop call chain #664

feat: read constants and storage when using pop call chain #664

Uh oh!

Conversation

moliholy commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Screenshots

Uh oh!

codecov bot commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AlexD10S left a comment

Choose a reason for hiding this comment

Uh oh!

al3mart left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

al3mart left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

moliholy commented Oct 16, 2025

Uh oh!

al3mart commented Oct 16, 2025

Uh oh!

moliholy commented Oct 16, 2025

Uh oh!

al3mart left a comment

Choose a reason for hiding this comment

Uh oh!

moliholy commented Oct 16, 2025

Uh oh!

al3mart left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

feat: read constants and storage when using `pop call chain` #664

feat: read constants and storage when using `pop call chain` #664

moliholy commented Oct 8, 2025 •

edited

Loading

codecov bot commented Oct 8, 2025 •

edited

Loading

al3mart left a comment •

edited

Loading

al3mart left a comment •

edited

Loading