feat: do not ask for confirmation when removing all in the cache #660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #660 +/- ##
==========================================
- Coverage 77.34% 77.33% -0.02%
==========================================
Files 109 109
Lines 25110 25073 -37
Branches 25110 25073 -37
==========================================
- Hits 19422 19389 -33
Misses 3713 3713
+ Partials 1975 1971 -4
🚀 New features to boost your workflow:
|
AlexD10S
approved these changes
Oct 8, 2025
Collaborator
AlexD10S
left a comment
AlexD10S
left a comment
There was a problem hiding this comment.
Looks good! I agree, improving the tool to work better with scripts is definitely worth it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #659.
This PR forces the cache removal when
--allis specified. Rationale: when selecting one by one the artifacts to remove from the cache, no extra confirmation is done. However, when selecting--alla confirmation is required, which prevents scripts to work properly.My proposal is to directly remove them all, instead of adding an extra flag. I think that second options adds close to zero value, and hence I prefer to keep things simple.