Skip to content

feat(cli): allow to choose a chain from a list #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
moliholy merged 6 commits into from
Oct 8, 2025
Merged

feat(cli): allow to choose a chain from a list #658

moliholy merged 6 commits into from
Oct 8, 2025

Conversation

@moliholy
Copy link
Collaborator

@moliholy moliholy commented Oct 7, 2025 •
edited
Loading

Closes #616.

This PR allows users to select a chain to call from a list of well-known RPCs.

Users can type to filter the results.

Screenshots

Screenshot 2025-10-07 at 18 05 56 Screenshot 2025-10-07 at 18 06 50 Screenshot 2025-10-07 at 18 06 59

@moliholy moliholy requested a review from AlexD10S October 7, 2025 16:11
@moliholy moliholy self-assigned this Oct 7, 2025
@codecov
Copy link

codecov bot commented Oct 7, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 82.82209% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.36%. Comparing base (6a98c9b) to head (e3cd4f3).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/pop-cli/src/common/chain.rs 84.82% 14 Missing and 8 partials ⚠️
crates/pop-cli/src/commands/call/chain.rs 40.00% 1 Missing and 2 partials ⚠️
crates/pop-cli/src/commands/up/rollup.rs 76.92% 0 Missing and 3 partials ⚠️ 
@@            Coverage Diff             @@
##             main     #658      +/-   ##
==========================================
+ Coverage   77.33%   77.36%   +0.03%     
==========================================
  Files         109      109              
  Lines       25073    25228     +155     
  Branches    25073    25228     +155     
==========================================
+ Hits        19389    19518     +129     
- Misses       3713     3728      +15     
- Partials     1971     1982      +11
Files with missing lines Coverage Δ
crates/pop-cli/src/commands/call/chain.rs 69.27% <40.00%> (-0.22%) ⬇️
crates/pop-cli/src/commands/up/rollup.rs 71.35% <76.92%> (-0.09%) ⬇️
crates/pop-cli/src/common/chain.rs 84.00% <84.82%> (+8.24%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@moliholy
Copy link
Collaborator Author

moliholy commented Oct 7, 2025

@AlexD10S just added the supports_contracts flag to check whether pallet-revive is included in the runtime or not 😎 .

@moliholy
Copy link
Collaborator Author

moliholy commented Oct 7, 2025

For completeness: this is the file being used to display the RPCs: https://github.com/r0gue-io/polkadot-chains/blob/master/endpoints.json

AlexD10S
AlexD10S reviewed Oct 8, 2025
View reviewed changes
Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome feature!
Thanks for adding the supportsContracts flag, that should make it easier to bring this feature to call contracts too.
Are we planning to implement it for pop call contracts once we only support pallet_revive no? Might be good to open an issue as a reminder.

Left a couple of minor comments only.

@moliholy
Copy link
Collaborator Author

moliholy commented Oct 8, 2025

Are we planning to implement it for pop call contracts once we only support pallet_revive no? Might be good to open an issue as a reminder.

@AlexD10S either that or we can do it under the v6 feature umbrella. As you prefer.

@moliholy moliholy mentioned this pull request Oct 8, 2025
Closed
@moliholy
Copy link
Collaborator Author

moliholy commented Oct 8, 2025 •
edited
Loading

@AlexD10S issue created! #661

AlexD10S
AlexD10S approved these changes Oct 8, 2025
View reviewed changes
Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@moliholy moliholy merged commit 0780e9b into main Oct 8, 2025
19 checks passed
@moliholy moliholy deleted the feat/choose-chain branch October 8, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexD10S AlexD10S AlexD10S approved these changes

Assignees

@moliholy moliholy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Offer the user a list of well-known chain RPCs to connect to when using pop call

3 participants

@moliholy @AlexD10S