feat: always build contracts with pop up #657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #657 +/- ##
==========================================
- Coverage 77.33% 77.32% -0.02%
==========================================
Files 109 109
Lines 24941 24947 +6
Branches 24941 24947 +6
==========================================
+ Hits 19288 19290 +2
- Misses 3678 3682 +4
Partials 1975 1975
🚀 New features to boost your workflow:
|
AlexD10S
approved these changes
Oct 7, 2025
Collaborator
AlexD10S
left a comment
AlexD10S
left a comment
There was a problem hiding this comment.
LGTM!
Just a nitpick, should we add the --skip-build flag in the integration test to avoid rebuilding it? https://github.com/r0gue-io/pop-cli/blob/main/crates/pop-cli/tests/contract.rs#L110
Collaborator
Author
|
@AlexD10S hmmmm it does not really matter. If it is already built it'll take no time to realize and continue with the process. I don't think it's necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #623.
This PR adds a
skip-buildcommand topop up contract.false, it will always rebuild the contract, even if it was already built. This is the default behaviour.true, it won't build the contract in advance, UNLESS it wasn't built already. If so, it'll be built, ignoring the--skip-buildflag.