Skip to content

feat: upgrade to rust edition 2024 #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
moliholy merged 2 commits into from
Oct 7, 2025
Merged

feat: upgrade to rust edition 2024 #656

moliholy merged 2 commits into from
Oct 7, 2025

Conversation

@moliholy
Copy link
Collaborator

@moliholy moliholy commented Oct 7, 2025

Closes #626.

Upgrades to Rust edition 2024.

There seems to be a change in how rustfmt sorts packages now, and that's why there are so many minor changes in imports all around the project.

@moliholy moliholy requested a review from AlexD10S October 7, 2025 10:28
@moliholy moliholy self-assigned this Oct 7, 2025
@codecov
Copy link

codecov bot commented Oct 7, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 80.45738% with 94 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.34%. Comparing base (fa9008d) to head (051cd03).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/pop-cli/src/commands/up/rollup.rs 66.66% 14 Missing and 6 partials ⚠️
crates/pop-cli/src/commands/new/chain.rs 0.00% 9 Missing ⚠️
crates/pop-cli/src/commands/call/chain.rs 75.00% 6 Missing and 2 partials ⚠️
crates/pop-cli/src/commands/new/pallet.rs 0.00% 8 Missing ⚠️
crates/pop-cli/src/commands/test/contract.rs 0.00% 8 Missing ⚠️
...rates/pop-cli/src/commands/test/create_snapshot.rs 0.00% 8 Missing ⚠️
crates/pop-cli/src/commands/up/network.rs 0.00% 7 Missing ⚠️
crates/pop-cli/src/common/try_runtime.rs 89.13% 1 Missing and 4 partials ⚠️
crates/pop-cli/src/commands/bench/pallet.rs 0.00% 4 Missing ⚠️
crates/pop-chains/src/up/chains.rs 83.33% 0 Missing and 3 partials ⚠️
... and 7 more 
@@            Coverage Diff             @@
##             main     #656      +/-   ##
==========================================
+ Coverage   77.32%   77.34%   +0.02%     
==========================================
  Files         109      109              
  Lines       24947    25110     +163     
  Branches    24947    25110     +163     
==========================================
+ Hits        19290    19422     +132     
- Misses       3682     3713      +31     
  Partials     1975     1975
Files with missing lines Coverage Δ
crates/pop-chains/src/bench/binary.rs 86.27% <ø> (ø)
crates/pop-chains/src/bench/mod.rs 87.17% <100.00%> (+0.33%) ⬆️
crates/pop-chains/src/build/mod.rs 88.65% <ø> (ø)
crates/pop-chains/src/build/runtime.rs 84.66% <100.00%> (+0.28%) ⬆️
crates/pop-chains/src/call/metadata/action.rs 94.93% <ø> (ø)
crates/pop-chains/src/call/metadata/mod.rs 95.12% <ø> (ø)
crates/pop-chains/src/call/metadata/params.rs 90.56% <ø> (ø)
crates/pop-chains/src/call/mod.rs 63.78% <ø> (ø)
crates/pop-chains/src/generator/pallet.rs 29.16% <ø> (ø)
crates/pop-chains/src/lib.rs 0.00% <ø> (ø)
... and 76 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

AlexD10S
AlexD10S approved these changes Oct 7, 2025
View reviewed changes
Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this upgrade

@moliholy moliholy requested a review from AlexD10S October 7, 2025 12:11
@moliholy
Copy link
Collaborator Author

moliholy commented Oct 7, 2025

@AlexD10S mind to re-approve? After merging another PR it is required to rebase and that resets the approvals.

@moliholy moliholy merged commit 259ca3a into main Oct 7, 2025
19 checks passed
@moliholy moliholy deleted the feat/edition-2024 branch October 7, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexD10S AlexD10S AlexD10S approved these changes

Assignees

@moliholy moliholy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Upgrade to Rust edition 2024

3 participants

@moliholy @AlexD10S