test: move some tests to integration tests #649

AlexD10S · 2025-09-30T08:02:19Z

Refactor to move most of pop bench tests to integration tests.
Small fixes in some tests for pop bench and try-runtime that were failing when running them alone with an empty cache.
Moved detects_contract_correctly that runs test in a contract to integration tests.

In the coverage job that runs unit test it improves time now from 55 minutes to 26.

codecov · 2025-09-30T16:08:04Z

Codecov Report

❌ Patch coverage is 63.93443% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.33%. Comparing base (98ef04c) to head (91e9976).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/pop-cli/src/commands/bench/pallet.rs	42.10%	6 Missing and 5 partials ⚠️
crates/pop-cli/src/commands/bench/overhead.rs	0.00%	7 Missing ⚠️
crates/pop-cli/src/commands/bench/block.rs	90.90%	0 Missing and 1 partial ⚠️
crates/pop-cli/src/commands/bench/machine.rs	90.00%	0 Missing and 1 partial ⚠️
crates/pop-cli/src/commands/bench/storage.rs	66.66%	0 Missing and 1 partial ⚠️
crates/pop-cli/src/commands/test/fast_forward.rs	0.00%	0 Missing and 1 partial ⚠️

@@            Coverage Diff             @@
##             main     #649      +/-   ##
==========================================
- Coverage   78.22%   77.33%   -0.90%     
==========================================
  Files         109      109              
  Lines       25459    24941     -518     
  Branches    25459    24941     -518     
==========================================
- Hits        19916    19288     -628     
- Misses       3474     3678     +204     
+ Partials     2069     1975      -94

Files with missing lines	Coverage Δ
...rates/pop-cli/src/commands/test/create_snapshot.rs	`73.09% <100.00%> (+0.31%)`	⬆️
crates/pop-cli/src/commands/test/execute_block.rs	`88.93% <100.00%> (+0.04%)`	⬆️
crates/pop-cli/src/commands/test/mod.rs	`70.14% <ø> (-4.55%)`	⬇️
...es/pop-cli/src/commands/test/on_runtime_upgrade.rs	`90.32% <100.00%> (+0.07%)`	⬆️
crates/pop-common/src/lib.rs	`81.94% <ø> (ø)`
crates/pop-cli/src/commands/bench/block.rs	`42.85% <90.90%> (-31.41%)`	⬇️
crates/pop-cli/src/commands/bench/machine.rs	`42.25% <90.00%> (-31.79%)`	⬇️
crates/pop-cli/src/commands/bench/storage.rs	`69.56% <66.66%> (-3.43%)`	⬇️
crates/pop-cli/src/commands/test/fast_forward.rs	`88.26% <0.00%> (-0.22%)`	⬇️
crates/pop-cli/src/commands/bench/overhead.rs	`44.54% <0.00%> (-28.73%)`	⬇️
... and 1 more

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

crates/pop-cli/src/commands/bench/block.rs

crates/pop-cli/src/commands/bench/machine.rs

crates/pop-cli/src/commands/bench/overhead.rs

crates/pop-cli/src/commands/bench/pallet.rs

crates/pop-cli/src/commands/test/execute_block.rs

crates/pop-cli/src/commands/test/fast_forward.rs

crates/pop-cli/src/commands/test/mod.rs

crates/pop-cli/src/commands/bench/machine.rs

crates/pop-cli/src/commands/bench/block.rs

crates/pop-cli/src/commands/bench/storage.rs

crates/pop-cli/src/commands/test/create_snapshot.rs

crates/pop-cli/src/commands/test/execute_block.rs

crates/pop-cli/src/commands/test/on_runtime_upgrade.rs

crates/pop-cli/tests/contract.rs

crates/pop-common/Cargo.toml

moliholy · 2025-10-01T13:03:29Z

LGTM!

AlexD10S force-pushed the ci/rust-version-docker-tests branch 2 times, most recently from 665277d to e8e124b Compare September 30, 2025 15:36

AlexD10S changed the base branch from main to ci/rust-version-docker September 30, 2025 16:11

Base automatically changed from ci/rust-version-docker to main September 30, 2025 16:46

AlexD10S force-pushed the ci/rust-version-docker-tests branch from 5c1b4cd to 0043b0f Compare September 30, 2025 17:31

AlexD10S marked this pull request as ready for review September 30, 2025 17:31

AlexD10S force-pushed the ci/rust-version-docker-tests branch from 0043b0f to 9d772c9 Compare September 30, 2025 18:57

AlexD10S changed the title ~~WIP - test(ci): ignore slow tests~~ test: move pop bench test to integration tests Sep 30, 2025

AlexD10S changed the title ~~test: move pop bench test to integration tests~~ test: move some tests to integration tests Sep 30, 2025