Skip to content

ci: several improvements #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
moliholy merged 12 commits into from
Sep 30, 2025
Merged

ci: several improvements #648

moliholy merged 12 commits into from
Sep 30, 2025

Conversation

@moliholy
Copy link
Collaborator

@moliholy moliholy commented Sep 29, 2025 •
edited
Loading

This PR:

  • Allows to specify the rust version when building the docker image. This way if we change the rust version in rust-toolchain.toml a new docker image will be created to run everything.
  • Gathers integration tests in a single feature. Integration tests should not count for the coverage.
  • Fixes a few conflictive tests.
  • Skips install checks if relevant source files not modified.

@moliholy moliholy self-assigned this Sep 29, 2025
@moliholy moliholy force-pushed the ci/rust-version-docker branch from c277279 to df4ffad Compare September 29, 2025 18:18
@moliholy moliholy requested a review from AlexD10S September 29, 2025 18:32
@moliholy moliholy marked this pull request as ready for review September 29, 2025 18:32
@moliholy moliholy changed the title ci: include the rust version in docker tag ci: several improvements Sep 29, 2025
@moliholy moliholy force-pushed the ci/rust-version-docker branch from 88111cf to ff87f98 Compare September 29, 2025 22:08
@moliholy moliholy force-pushed the ci/rust-version-docker branch from ff87f98 to 0dc5409 Compare September 29, 2025 22:09
@AlexD10S AlexD10S mentioned this pull request Sep 30, 2025
Closed
@codecov
Copy link

codecov bot commented Sep 30, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.18%. Comparing base (69cfcce) to head (43905c7).
⚠️ Report is 1 commits behind head on main.

@@            Coverage Diff             @@
##             main     #648      +/-   ##
==========================================
+ Coverage   78.16%   78.18%   +0.02%     
==========================================
  Files         109      109              
  Lines       25464    25465       +1     
  Branches    25464    25465       +1     
==========================================
+ Hits        19903    19910       +7     
- Misses       3481     3483       +2     
+ Partials     2080     2072       -8
Files with missing lines Coverage Δ
...rates/pop-cli/src/commands/test/create_snapshot.rs 72.78% <100.00%> (ø)
crates/pop-cli/src/commands/test/execute_block.rs 89.28% <100.00%> (ø)
crates/pop-cli/src/common/binary.rs 72.99% <100.00%> (+0.19%) ⬆️

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@moliholy moliholy force-pushed the ci/rust-version-docker branch from 9dd6e82 to 72e0f7b Compare September 30, 2025 14:53
@moliholy moliholy force-pushed the ci/rust-version-docker branch from 72e0f7b to 43905c7 Compare September 30, 2025 15:34
AlexD10S
AlexD10S approved these changes Sep 30, 2025
View reviewed changes
Copy link
Collaborator

@AlexD10S AlexD10S left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! Let’s wait for CI, and if it’s green we merge to unblock all the pending PRs.

@moliholy moliholy merged commit 78277a7 into main Sep 30, 2025
24 checks passed
@moliholy moliholy deleted the ci/rust-version-docker branch September 30, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexD10S AlexD10S AlexD10S approved these changes

Assignees

@moliholy moliholy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@moliholy @AlexD10S