-
Notifications
You must be signed in to change notification settings - Fork 40
chore: pop build spec improvements
#640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
AlexD10S
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
pop build spec improvementspop build spec improvements
|
@AlexD10S mind to merge? I have no permission to do it if the CI is failing. |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #640 +/- ##
==========================================
+ Coverage 78.18% 78.21% +0.03%
==========================================
Files 109 109
Lines 25465 25461 -4
Branches 25465 25461 -4
==========================================
+ Hits 19910 19915 +5
+ Misses 3483 3477 -6
+ Partials 2072 2069 -3
🚀 New features to boost your workflow:
|
Closes #642.
This PR enhances the
pop build specso that it can:pathargument) instead of assuming it is the current directory. This allow thepop build specto work from any directory in the system. By default the current directory keeps being used if not specified.