Skip to content

Conversation

@moliholy
Copy link
Collaborator

@moliholy moliholy commented Sep 25, 2025

Closes #642.

This PR enhances the pop build spec so that it can:

  • Specify the base directory (path argument) instead of assuming it is the current directory. This allow the pop build spec to work from any directory in the system. By default the current directory keeps being used if not specified.
  • Changes clap arguments to allow the command to be executed in a non-interactive manner. This way the command can be embedded in bash scripts, for example.

@moliholy moliholy requested a review from AlexD10S September 25, 2025 13:36
@moliholy moliholy self-assigned this Sep 25, 2025
@moliholy moliholy changed the title pop build spec improvements pop build spec improvements Sep 26, 2025
Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AlexD10S AlexD10S changed the title pop build spec improvements chore: pop build spec improvements Sep 26, 2025
@moliholy
Copy link
Collaborator Author

moliholy commented Sep 29, 2025

@AlexD10S mind to merge? I have no permission to do it if the CI is failing.

@moliholy moliholy requested a review from AlexD10S September 30, 2025 17:10
@codecov
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

❌ Patch coverage is 86.44068% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.21%. Comparing base (78277a7) to head (3d95488).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/pop-cli/src/commands/build/spec.rs 91.07% 2 Missing and 3 partials ⚠️
crates/pop-cli/src/commands/up/rollup.rs 0.00% 2 Missing ⚠️
crates/pop-cli/src/commands/test/execute_block.rs 0.00% 0 Missing and 1 partial ⚠️
@@            Coverage Diff             @@
##             main     #640      +/-   ##
==========================================
+ Coverage   78.18%   78.21%   +0.03%     
==========================================
  Files         109      109              
  Lines       25465    25461       -4     
  Branches    25465    25461       -4     
==========================================
+ Hits        19910    19915       +5     
+ Misses       3483     3477       -6     
+ Partials     2072     2069       -3     
Files with missing lines Coverage Δ
crates/pop-cli/src/commands/test/execute_block.rs 88.88% <0.00%> (-0.40%) ⬇️
crates/pop-cli/src/commands/up/rollup.rs 71.37% <0.00%> (ø)
crates/pop-cli/src/commands/build/spec.rs 77.44% <91.07%> (+1.13%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@moliholy moliholy merged commit e806303 into main Sep 30, 2025
19 checks passed
@moliholy moliholy deleted the feat/build-spec-improvements branch September 30, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make all pop commands shell-compatible

3 participants