Skip to content

Conversation

@moliholy
Copy link
Collaborator

Closes #559

This PR allows users to keep interacting with the contract after deployment.

@moliholy moliholy requested a review from AlexD10S September 10, 2025 13:33
@moliholy moliholy self-assigned this Sep 10, 2025
@moliholy moliholy force-pushed the feat/node-keep-alive branch from 320f404 to 2366838 Compare September 11, 2025 08:14
@codecov
Copy link

codecov bot commented Sep 11, 2025

Codecov Report

❌ Patch coverage is 28.57143% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.16%. Comparing base (6fe3154) to head (f66ffae).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
crates/pop-cli/src/commands/up/contract.rs 0.00% 22 Missing ⚠️
crates/pop-cli/src/commands/call/contract.rs 83.33% 2 Missing ⚠️
crates/pop-cli/src/common/contracts.rs 0.00% 0 Missing and 1 partial ⚠️
@@            Coverage Diff             @@
##             main     #629      +/-   ##
==========================================
+ Coverage   77.10%   78.16%   +1.06%     
==========================================
  Files         109      109              
  Lines       25004    25464     +460     
  Branches    25004    25464     +460     
==========================================
+ Hits        19279    19904     +625     
+ Misses       3708     3481     -227     
- Partials     2017     2079      +62     
Files with missing lines Coverage Δ
crates/pop-cli/src/common/contracts.rs 82.60% <0.00%> (-0.22%) ⬇️
crates/pop-cli/src/commands/call/contract.rs 68.14% <83.33%> (+0.27%) ⬆️
crates/pop-cli/src/commands/up/contract.rs 13.60% <0.00%> (-0.73%) ⬇️

... and 14 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So cool! The DevEx of pop up contract and pop call contract improves a lot with this PR and #622

@moliholy moliholy force-pushed the feat/node-keep-alive branch from 2366838 to 6f8e3aa Compare September 11, 2025 12:05
@moliholy moliholy force-pushed the feat/node-keep-alive branch 8 times, most recently from d91f0ed to 8c2e8f4 Compare September 12, 2025 13:26
@moliholy moliholy force-pushed the feat/node-keep-alive branch 12 times, most recently from ffd9b49 to 7482511 Compare September 13, 2025 01:04
@moliholy moliholy requested a review from AlexD10S September 13, 2025 01:58
@moliholy
Copy link
Collaborator Author

@AlexD10S finally managed to fix the build! Now it's ready to review again.

@moliholy moliholy force-pushed the feat/node-keep-alive branch from 0d1692e to f66ffae Compare September 14, 2025 11:57
@moliholy moliholy merged commit 8dd893c into main Sep 14, 2025
23 of 24 checks passed
@moliholy moliholy deleted the feat/node-keep-alive branch September 14, 2025 14:38
@AlexD10S AlexD10S mentioned this pull request Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Further interact with contract after deployment

3 participants