Skip to content

Conversation

@AlexD10S
Copy link
Collaborator

@AlexD10S AlexD10S commented Sep 10, 2025

Closes #552

  • Deprecates the evm-parachain template.
  • Deprecates the Parity substrate-contracts-node too (no longer maintained).

Context on the deprecation policy: Deprecated templates are hidden from the pop new chain list, but keeps them usable via explicit CLI invocation (to avoid breaking existing scripts). And include a internal comment in the code to know on with version will be removed.

@codecov
Copy link

codecov bot commented Sep 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.20%. Comparing base (6fe3154) to head (8435a65).
⚠️ Report is 5 commits behind head on main.

@@            Coverage Diff             @@
##             main     #628      +/-   ##
==========================================
+ Coverage   77.10%   78.20%   +1.10%     
==========================================
  Files         109      109              
  Lines       25004    25438     +434     
  Branches    25004    25438     +434     
==========================================
+ Hits        19279    19894     +615     
+ Misses       3708     3464     -244     
- Partials     2017     2080      +63     
Files with missing lines Coverage Δ
crates/pop-chains/src/templates.rs 98.93% <100.00%> (ø)
crates/pop-cli/src/commands/new/chain.rs 50.59% <ø> (+35.10%) ⬆️

... and 13 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AlexD10S AlexD10S requested a review from moliholy September 10, 2025 14:56
Copy link
Collaborator

@moliholy moliholy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexD10S AlexD10S merged commit b11cc2d into main Sep 12, 2025
37 of 38 checks passed
@AlexD10S AlexD10S deleted the chore/deprecate-evm branch September 12, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate evm-parachain template

3 participants