Skip to content

Conversation

@AlexD10S
Copy link
Collaborator

@AlexD10S AlexD10S commented Sep 9, 2025

Remove the deny job from CI: it’s producing frequent failures due to new upstream advisories on transitive deps, even when none new dependency has been added.

I keep deny.toml in the repo for local checks and future re-enablement with a quick explanation on how to use it in the README.

@moliholy
Copy link
Collaborator

moliholy commented Sep 9, 2025

@AlexD10S you can run a separate workflow that can only be run manually, if you want.

@codecov
Copy link

codecov bot commented Sep 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.10%. Comparing base (6fe3154) to head (e0c7885).
⚠️ Report is 1 commits behind head on main.

@@           Coverage Diff           @@
##             main     #627   +/-   ##
=======================================
  Coverage   77.10%   77.10%           
=======================================
  Files         109      109           
  Lines       25004    25004           
  Branches    25004    25004           
=======================================
  Hits        19279    19279           
  Misses       3708     3708           
  Partials     2017     2017           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AlexD10S
Copy link
Collaborator Author

AlexD10S commented Sep 9, 2025

@AlexD10S you can run a separate workflow that can only be run manually, if you want.

Is possible, but how do you see the benefit on having it in a CI that has to be run manually? If red, it will still requires local fixes, and running it locally with our deny.toml gives the same signal.

@AlexD10S AlexD10S requested a review from moliholy September 9, 2025 15:35
@moliholy
Copy link
Collaborator

moliholy commented Sep 9, 2025

Is possible, but how do you see the benefit on having it in a CI that has to be run manually?

Fair point. Just the heads up in case you consider it worth to be added that way. But also adding instructions on how to do it is perfectly fine as well 👍 .

Copy link
Collaborator

@moliholy moliholy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AlexD10S AlexD10S merged commit 7fd2c95 into main Sep 9, 2025
23 checks passed
@AlexD10S AlexD10S deleted the chore/remove-deny-ci branch September 9, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants