Skip to content

fix: all clippy warnings #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
moliholy merged 6 commits into from
Sep 10, 2025
Merged

fix: all clippy warnings #625

moliholy merged 6 commits into from
Sep 10, 2025

Conversation

@moliholy
Copy link
Collaborator

@moliholy moliholy commented Sep 9, 2025

This PR fixes all clippy warnings and adds a CI check that fails the build if new ones are introduced.

@moliholy moliholy requested a review from AlexD10S September 9, 2025 12:16
@moliholy moliholy self-assigned this Sep 9, 2025
@moliholy moliholy force-pushed the fix/clippy-warnings branch from b3a1547 to 456725d Compare September 9, 2025 12:19
@codecov
Copy link

codecov bot commented Sep 9, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 83.33333% with 66 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.08%. Comparing base (6fe3154) to head (b5f8962).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/pop-chains/src/up/mod.rs 22.72% 0 Missing and 17 partials ⚠️
crates/pop-chains/src/build/mod.rs 46.66% 0 Missing and 8 partials ⚠️
crates/pop-contracts/src/up.rs 0.00% 5 Missing ⚠️
crates/pop-common/src/templates/extractor.rs 20.00% 0 Missing and 4 partials ⚠️
crates/pop-cli/src/commands/up/contract.rs 25.00% 3 Missing ⚠️
crates/pop-cli/src/common/contracts.rs 40.00% 0 Missing and 3 partials ⚠️
crates/pop-common/src/git.rs 0.00% 0 Missing and 3 partials ⚠️
crates/pop-cli/src/commands/build/runtime.rs 0.00% 1 Missing and 1 partial ⚠️
crates/pop-cli/src/common/runtime.rs 33.33% 0 Missing and 2 partials ⚠️
crates/pop-contracts/src/call.rs 0.00% 2 Missing ⚠️
... and 17 more 
@@            Coverage Diff             @@
##             main     #625      +/-   ##
==========================================
- Coverage   77.10%   77.08%   -0.02%     
==========================================
  Files         109      109              
  Lines       25004    24988      -16     
  Branches    25004    24988      -16     
==========================================
- Hits        19279    19262      -17     
- Misses       3708     3709       +1     
  Partials     2017     2017
Files with missing lines Coverage Δ
crates/pop-chains/src/registry/mod.rs 100.00% <100.00%> (ø)
crates/pop-chains/src/registry/pop.rs 99.13% <100.00%> (ø)
crates/pop-chains/src/registry/system.rs 99.19% <100.00%> (ø)
crates/pop-chains/src/templates.rs 98.93% <100.00%> (ø)
crates/pop-chains/src/utils/helpers.rs 80.43% <100.00%> (ø)
crates/pop-cli/src/cli.rs 59.61% <100.00%> (ø)
crates/pop-cli/src/commands/bench/overhead.rs 85.39% <100.00%> (ø)
crates/pop-cli/src/commands/build/spec.rs 76.30% <100.00%> (ø)
crates/pop-cli/src/commands/call/contract.rs 67.87% <100.00%> (ø)
crates/pop-cli/src/commands/clean.rs 82.82% <100.00%> (-0.70%) ⬇️
... and 42 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@moliholy moliholy marked this pull request as ready for review September 9, 2025 14:46
@moliholy moliholy force-pushed the fix/clippy-warnings branch from f0184ab to 88b1447 Compare September 9, 2025 15:56
AlexD10S
AlexD10S reviewed Sep 9, 2025
View reviewed changes
@moliholy moliholy force-pushed the fix/clippy-warnings branch from 88b1447 to b5f8962 Compare September 9, 2025 18:25
AlexD10S
AlexD10S approved these changes Sep 9, 2025
View reviewed changes
Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, it’s been needed for quite some time.

@AlexD10S AlexD10S changed the title Fix all clippy warnings fix: all clippy warnings Sep 9, 2025
@moliholy moliholy requested a review from AlexD10S September 10, 2025 11:06
@moliholy moliholy merged commit c5a6283 into main Sep 10, 2025
20 of 21 checks passed
@moliholy moliholy deleted the fix/clippy-warnings branch September 10, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexD10S AlexD10S AlexD10S approved these changes

Assignees

@moliholy moliholy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@moliholy @AlexD10S