Skip to content

Conversation

@moliholy
Copy link
Collaborator

@moliholy moliholy commented Sep 8, 2025

Closes #555

This PR allows users to follow the logs instead of detaching the contracts node. This way users have access to the logs and can keep interacting with the node.

Example

Screenshot 2025-09-08 at 22 33 03

@moliholy moliholy force-pushed the feat/attach-node-logs branch from 8dda377 to 612fb54 Compare September 8, 2025 19:51
@moliholy moliholy force-pushed the feat/attach-node-logs branch from c25a643 to d1684ea Compare September 9, 2025 08:02
@moliholy moliholy self-assigned this Sep 9, 2025
@moliholy moliholy force-pushed the feat/attach-node-logs branch from 6a9095f to 28af147 Compare September 9, 2025 10:11
@codecov
Copy link

codecov bot commented Sep 9, 2025

Codecov Report

❌ Patch coverage is 12.50000% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.09%. Comparing base (d63177f) to head (28af147).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/pop-cli/src/commands/up/contract.rs 0.00% 9 Missing ⚠️
crates/pop-cli/src/common/contracts.rs 28.57% 5 Missing ⚠️
@@            Coverage Diff             @@
##             main     #622      +/-   ##
==========================================
- Coverage   77.11%   77.09%   -0.02%     
==========================================
  Files         109      109              
  Lines       25001    25004       +3     
  Branches    25001    25004       +3     
==========================================
- Hits        19279    19278       -1     
- Misses       3705     3709       +4     
  Partials     2017     2017              
Files with missing lines Coverage Δ
crates/pop-cli/src/common/contracts.rs 82.82% <28.57%> (-1.56%) ⬇️
crates/pop-cli/src/commands/up/contract.rs 14.33% <0.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@moliholy moliholy merged commit 6fe3154 into main Sep 9, 2025
21 of 24 checks passed
@moliholy moliholy deleted the feat/attach-node-logs branch September 9, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Kill the ink-node automatically

3 participants