Skip to content

Conversation

@moliholy
Copy link
Collaborator

@moliholy moliholy commented Sep 5, 2025

Closes #610

This PR avoids asking every time to the user wether the call should be run with sudo or not.

Instead, it simply asks the user to confirm its decision if the --root flag is specified.

Example:

Screenshot 2025-09-05 at 17 22 53

@moliholy moliholy requested review from AlexD10S and al3mart September 5, 2025 15:19
@moliholy moliholy self-assigned this Sep 5, 2025
Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@codecov
Copy link

codecov bot commented Sep 5, 2025

Codecov Report

❌ Patch coverage is 81.81818% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.08%. Comparing base (0621dbe) to head (ee8a2bf).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
crates/pop-cli/src/commands/call/chain.rs 81.81% 2 Missing and 2 partials ⚠️
@@            Coverage Diff             @@
##             main     #620      +/-   ##
==========================================
+ Coverage   77.04%   77.08%   +0.03%     
==========================================
  Files         109      109              
  Lines       24873    24963      +90     
  Branches    24873    24963      +90     
==========================================
+ Hits        19164    19243      +79     
+ Misses       3705     3704       -1     
- Partials     2004     2016      +12     
Files with missing lines Coverage Δ
crates/pop-cli/src/commands/call/chain.rs 69.68% <81.81%> (+0.81%) ⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@moliholy moliholy merged commit c56b253 into main Sep 5, 2025
23 of 24 checks passed
@moliholy moliholy deleted the feat/improve-sudo-question branch September 5, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not ask for sudo confirmation

3 participants