fix: process user input for Strings and None values #618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #618 +/- ##
==========================================
+ Coverage 77.04% 77.08% +0.03%
==========================================
Files 109 109
Lines 24873 25002 +129
Branches 24873 25002 +129
==========================================
+ Hits 19164 19273 +109
- Misses 3705 3712 +7
- Partials 2004 2017 +13
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
moliholy
approved these changes
Sep 8, 2025
Collaborator
moliholy
left a comment
moliholy
left a comment
There was a problem hiding this comment.
LGTM! Very clean and straightforward PR ✨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the handling of user-provided arguments for contract calls:
Strings: User input is automatically normalized to ensure values are wrapped in double quotes (if not already).
Closes Strings are not escpade. #408
None values: User input "None" is automatically normalized to an empty string ("").
Closes Improve input
Noneas contract argument #579