Skip to content

Conversation

@moliholy
Copy link
Collaborator

@moliholy moliholy commented Sep 5, 2025

This PR greatly improves building times in CI by:

  • By using an exhaustive caching mechanism per branch.
  • Using a custom docker image to avoid always reinstalling the same dependencies.

@moliholy moliholy requested a review from AlexD10S September 5, 2025 10:09
@moliholy moliholy self-assigned this Sep 5, 2025
@moliholy moliholy force-pushed the ci/docker branch 4 times, most recently from d627af1 to 8583d09 Compare September 5, 2025 12:24
@moliholy moliholy force-pushed the ci/docker branch 6 times, most recently from 572eba6 to 0a244c2 Compare September 5, 2025 13:28
@moliholy moliholy force-pushed the ci/docker branch 4 times, most recently from 70d7e61 to e1b74ad Compare September 5, 2025 13:38
@moliholy moliholy force-pushed the ci/docker branch 4 times, most recently from a2e71bc to 384ed2a Compare September 5, 2025 14:01
@codecov
Copy link

codecov bot commented Sep 11, 2025

Codecov Report

❌ Patch coverage is 28.12500% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.83%. Comparing base (6fe3154) to head (ac73c40).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
crates/pop-cli/src/commands/bench/pallet.rs 7.14% 0 Missing and 13 partials ⚠️
crates/pop-cli/src/common/contracts.rs 36.36% 4 Missing and 3 partials ⚠️
crates/pop-chains/src/try_runtime/binary.rs 50.00% 0 Missing and 2 partials ⚠️
crates/pop-chains/src/build/runtime.rs 0.00% 0 Missing and 1 partial ⚠️
@@            Coverage Diff             @@
##             main     #617      +/-   ##
==========================================
- Coverage   77.10%   76.83%   -0.28%     
==========================================
  Files         109      109              
  Lines       25004    25018      +14     
  Branches    25004    25018      +14     
==========================================
- Hits        19279    19222      -57     
- Misses       3708     3772      +64     
- Partials     2017     2024       +7     
Files with missing lines Coverage Δ
crates/pop-chains/src/new_pallet.rs 73.41% <100.00%> (+0.07%) ⬆️
crates/pop-cli/src/commands/bench/overhead.rs 72.72% <ø> (-12.68%) ⬇️
crates/pop-chains/src/build/runtime.rs 84.37% <0.00%> (ø)
crates/pop-chains/src/try_runtime/binary.rs 85.41% <50.00%> (+0.31%) ⬆️
crates/pop-cli/src/common/contracts.rs 82.60% <36.36%> (-0.22%) ⬇️
crates/pop-cli/src/commands/bench/pallet.rs 79.91% <7.14%> (-0.29%) ⬇️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! thanks for your time and patience on this PR. Looks great; happy to merge.

@moliholy moliholy merged commit ed3e0fc into main Sep 11, 2025
30 of 33 checks passed
@moliholy moliholy deleted the ci/docker branch September 11, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants