Skip to content

Conversation

@moliholy
Copy link
Collaborator

@moliholy moliholy commented Sep 4, 2025

Closes #611

This PR showcases those operations in smart contracts that imply sending an extrinsic from those that merely read from the storage.

Screenshots

fb46c62a-da17-4618-bebb-65d39bb82877 fb46c62a-da17-4618-bebb-65d39bb82877

@moliholy moliholy requested a review from AlexD10S September 4, 2025 14:31
@moliholy moliholy self-assigned this Sep 4, 2025
@codecov
Copy link

codecov bot commented Sep 4, 2025

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 77.06%. Comparing base (0621dbe) to head (8f29ade).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/pop-cli/src/cli.rs 0.00% 0 Missing and 1 partial ⚠️
@@            Coverage Diff             @@
##             main     #614      +/-   ##
==========================================
+ Coverage   77.04%   77.06%   +0.02%     
==========================================
  Files         109      109              
  Lines       24873    24965      +92     
  Branches    24873    24965      +92     
==========================================
+ Hits        19164    19240      +76     
- Misses       3705     3709       +4     
- Partials     2004     2016      +12     
Files with missing lines Coverage Δ
crates/pop-cli/src/commands/call/contract.rs 67.95% <100.00%> (+0.04%) ⬆️
crates/pop-cli/src/cli.rs 59.61% <0.00%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
I tested it on a contract with a long list of messages, and it’s really useful for quickly seeing which ones write to state and which ones are read-only.

@moliholy moliholy merged commit 4cd7ab1 into main Sep 5, 2025
24 checks passed
@moliholy moliholy deleted the feat/pop-call-write-ops branch September 5, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Distinguish between read and write operations in contract calls

3 participants