Skip to content

Conversation

@moliholy
Copy link
Collaborator

@moliholy moliholy commented Sep 3, 2025

Closes #560

This PR allows to use pop call without specifying contract or chain by checking the current directory.

Example

Success case

Screenshot 2025-09-03 at 19 03 14

Failure case

Screenshot 2025-09-03 at 19 37 41

@moliholy moliholy requested a review from AlexD10S September 3, 2025 17:33
@moliholy moliholy self-assigned this Sep 3, 2025
@moliholy moliholy changed the title feat(cli): autodtect target when invoking pop call without subcommand feat(cli): autodetect target when invoking pop call without subcommand Sep 3, 2025
@moliholy moliholy force-pushed the feat/pop-call-autodetect branch from c1864f6 to 1fe9be8 Compare September 3, 2025 17:34
Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Cool to have this improvement in pop call too

@codecov
Copy link

codecov bot commented Sep 4, 2025

Codecov Report

❌ Patch coverage is 84.61538% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.07%. Comparing base (0621dbe) to head (46c866b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/pop-cli/src/commands/call/mod.rs 81.60% 3 Missing and 13 partials ⚠️
crates/pop-cli/src/commands/mod.rs 75.00% 2 Missing ⚠️
@@            Coverage Diff             @@
##             main     #609      +/-   ##
==========================================
+ Coverage   77.04%   77.07%   +0.02%     
==========================================
  Files         109      109              
  Lines       24873    24964      +91     
  Branches    24873    24964      +91     
==========================================
+ Hits        19164    19240      +76     
- Misses       3705     3708       +3     
- Partials     2004     2016      +12     
Files with missing lines Coverage Δ
crates/pop-cli/src/commands/call/contract.rs 67.91% <100.00%> (ø)
crates/pop-cli/src/main.rs 88.08% <100.00%> (ø)
crates/pop-cli/src/commands/mod.rs 70.11% <75.00%> (+0.07%) ⬆️
crates/pop-cli/src/commands/call/mod.rs 83.50% <81.60%> (-16.50%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@moliholy moliholy merged commit 55f652d into main Sep 4, 2025
24 checks passed
@moliholy moliholy deleted the feat/pop-call-autodetect branch September 4, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pop call recognises project

3 participants