Skip to content

Conversation

@moliholy
Copy link
Collaborator

@moliholy moliholy commented Sep 1, 2025

This PR:

  • Removes the experimental and hashing features.
  • Uses plain output in the hashing command.
  • Removes the leading 0x from the output.

Example

Screenshot 2025-09-01 at 13 50 18

@moliholy moliholy requested a review from AlexD10S September 1, 2025 11:53
@moliholy moliholy self-assigned this Sep 1, 2025
@moliholy moliholy force-pushed the remove-experimental-feature branch from 2bc65d4 to e71ba0b Compare September 1, 2025 12:10
@moliholy moliholy changed the title Improve hashing command Improve the hashing command Sep 1, 2025
@moliholy moliholy force-pushed the remove-experimental-feature branch from e71ba0b to 11a7697 Compare September 1, 2025 12:36
Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Let's finish #582 to pass all the tests and then we can merge this one and its documentation: r0gue-io/pop-docs#45

@moliholy moliholy force-pushed the remove-experimental-feature branch from eda858a to 4e507a3 Compare September 2, 2025 21:27
@moliholy
Copy link
Collaborator Author

moliholy commented Sep 3, 2025

@AlexD10S tests passing already!

@AlexD10S AlexD10S self-requested a review September 3, 2025 06:44
@AlexD10S AlexD10S changed the title Improve the hashing command chore: Improve the hashing command Sep 3, 2025
@AlexD10S AlexD10S merged commit 60ff658 into main Sep 3, 2025
22 checks passed
@AlexD10S AlexD10S deleted the remove-experimental-feature branch September 3, 2025 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants