feat: allow to run a network by specifying its configuration #594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexD10S
approved these changes
Aug 28, 2025
Collaborator
AlexD10S
left a comment
AlexD10S
left a comment
There was a problem hiding this comment.
Nice and clean! No worries about the unit tests, in this specific case it’s complicated to have a unit test. We do have an integration test that runs pop up network ./network.toml, which we could adapt to run only pop up ./network.toml (https://github.com/r0gue-io/pop-cli/blob/main/crates/pop-cli/tests/chain.rs?utm_source=chatgpt.com#L155) But I don’t think it’s necessary for this PR.
As said in another PR the CI is currently failing on the unit tests job, but that’s unrelated to this PR. We’re already working on fixing the tests here: #582
AlexD10S
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #511
This PR allows to directly specify the network configuration file without the need of specifying the
networkkeyword. Like this:Couldn't add unit tests since it actually spins up the network and the process never finished. Happy to implement solutions for that with more feedback.