Skip to content

Autoremove the network's base directory upon tearing down #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AlexD10S merged 3 commits into from
Sep 3, 2025
Merged

Autoremove the network's base directory upon tearing down #591

AlexD10S merged 3 commits into from
Sep 3, 2025

Conversation

@moliholy
Copy link
Collaborator

@moliholy moliholy commented Aug 14, 2025 •
edited
Loading

Closes #585

This PR enables the --rm flag for removing the network's data upon tearing down the network. It can be used this way:

pop up network network.toml --rm

@codecov
Copy link

codecov bot commented Aug 15, 2025

Codecov Report

❌ Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.26%. Comparing base (607512e) to head (3b2fd2b).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
crates/pop-cli/src/commands/up/network.rs 0.00% 10 Missing ⚠️ 
@@            Coverage Diff             @@
##             main     #591      +/-   ##
==========================================
- Coverage   79.36%   79.26%   -0.11%     
==========================================
  Files         106      107       +1     
  Lines       25979    26060      +81     
  Branches    25979    26060      +81     
==========================================
+ Hits        20619    20657      +38     
- Misses       3073     3110      +37     
- Partials     2287     2293       +6
Files with missing lines Coverage Δ
crates/pop-cli/src/commands/up/network.rs 6.88% <0.00%> (-0.16%) ⬇️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AlexD10S AlexD10S self-requested a review August 28, 2025 08:10
@AlexD10S AlexD10S mentioned this pull request Aug 28, 2025
Closed
AlexD10S
AlexD10S approved these changes Aug 28, 2025
View reviewed changes
Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement! From this idea, I’ve also opened an issue to remove old data with the pop clean command: #598

The CI is currently failing on the unit tests job, but that’s unrelated to this PR. We’re already working on fixing the tests here: #582

@moliholy moliholy self-assigned this Sep 2, 2025
@moliholy moliholy force-pushed the feat/autoremove-network branch from 3b2fd2b to 7b1101f Compare September 2, 2025 13:27
@moliholy moliholy force-pushed the feat/autoremove-network branch from 7b1101f to 69a7007 Compare September 2, 2025 21:32
@AlexD10S AlexD10S merged commit 5a5b6c3 into r0gue-io:main Sep 3, 2025
30 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexD10S AlexD10S AlexD10S approved these changes

Assignees

@moliholy moliholy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

pop up throw away

2 participants

@moliholy @AlexD10S