Skip to content

Change parachain command to chain for consistency #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AlexD10S merged 22 commits into from
Jul 31, 2025
Merged

Change parachain command to chain for consistency #564

AlexD10S merged 22 commits into from
Jul 31, 2025

Conversation

@ical10
Copy link
Contributor

@ical10 ical10 commented Jul 8, 2025 •
edited
Loading

Objective

Closes #414

Overview

This PR contains modifications of command chain into parachain (and all of its references) so it's consistent across CLI.

E.g. earlier when we want to call a parachain, we do:

pop call parachain

Now it's changed to:

pop call chain

so it's the same command everywhere on the CLI.

What Changes in This PR

  • Subcommands and aliases (pop new, pop call, pop up)
  • CLI comments and descriptions
  • in-line code comments
  • any other references to subcommands anywhere else (docs, test codes, etc.)

Test

Running cargo test --test chain and passing all tests:

test parachain_lifecycle ... ok

test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 1421.18s

     Running tests/parachain.rs (target/debug/deps/parachain-08cc3700853e22a1)

running 6 tests
test launch_paseo ... ok
test launch_kusama ... ok
test launch_polkadot ... ok
test launch_paseo_and_system_parachain ... ok
test launch_polkadot_and_system_parachain ... ok
test launch_paseo_and_two_parachains has been running for over 60 seconds
test launch_paseo_and_two_parachains ... ok

test result: ok. 6 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 66.00s

Note

Need to change the command referenced here (for pop new parachain and pop up parachain).

@ical10
Copy link
Contributor Author

ical10 commented Jul 8, 2025

Hey @Daanvdplas if you can review this, that would be great :)

@Daanvdplas
Copy link
Collaborator

Daanvdplas commented Jul 8, 2025

@ical10 you are the absolute man that you picked this up!

Unfortunately the goal is to change it the other way around, so we want to have chain in stead of parachain.

Would you be willing to finish it? That would be amazing!

@ical10
Copy link
Contributor Author

ical10 commented Jul 8, 2025

@Daanvdplas Oh, I misunderstood. Should have clarified earlier.

But yes, I'll finish it.

@AlexD10S AlexD10S self-requested a review July 10, 2025 07:15
@Daanvdplas
Copy link
Collaborator

Daanvdplas commented Jul 11, 2025

He @ical10 would you be able to finish it before next week monday?

We would like to do a release then before the web3summit hackathon :)

@ical10
Copy link
Contributor Author

ical10 commented Jul 11, 2025

Hey @Daanvdplas thanks for checking in. I'll do my best during the weekend. Will mention you once the PR is ready.

@Daanvdplas
Copy link
Collaborator

Daanvdplas commented Jul 11, 2025

Much appreciated @ical10!

@ical10 ical10 changed the title Change chain command to parachain for consistency Change parachain command to chain for consistency Jul 12, 2025
@ical10
Copy link
Contributor Author

ical10 commented Jul 12, 2025

I think I've covered all of them, please let me know if there's any feedback :)
@Daanvdplas

Daanvdplas
Daanvdplas reviewed Jul 15, 2025
View reviewed changes
Daanvdplas
Daanvdplas reviewed Jul 15, 2025
View reviewed changes
Daanvdplas
Daanvdplas reviewed Jul 15, 2025
View reviewed changes
Daanvdplas
Daanvdplas reviewed Jul 15, 2025
View reviewed changes
Daanvdplas
Daanvdplas reviewed Jul 15, 2025
View reviewed changes
Copy link
Collaborator

@Daanvdplas Daanvdplas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!I I took a quick look and found some parachain usages.

Perhaps search for the word Parachain / parachain to find any other remaining cases.

@codecov
Copy link

codecov bot commented Jul 15, 2025

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.36%. Comparing base (607512e) to head (0a08bad).

Files with missing lines Patch % Lines
crates/pop-cli/src/commands/new/chain.rs 60.00% 2 Missing ⚠️
crates/pop-cli/src/commands/mod.rs 50.00% 1 Missing ⚠️ 
@@           Coverage Diff           @@
##             main     #564   +/-   ##
=======================================
  Coverage   79.36%   79.36%           
=======================================
  Files         106      106           
  Lines       25979    25979           
  Branches    25979    25979           
=======================================
  Hits        20619    20619           
  Misses       3073     3073           
  Partials     2287     2287
Files with missing lines Coverage Δ
crates/pop-cli/src/commands/build/chain.rs 76.76% <ø> (ø)
crates/pop-cli/src/commands/build/mod.rs 68.92% <ø> (ø)
crates/pop-cli/src/commands/call/mod.rs 100.00% <ø> (ø)
crates/pop-cli/src/commands/new/mod.rs 100.00% <100.00%> (ø)
crates/pop-cli/src/commands/up/mod.rs 79.84% <ø> (ø)
crates/pop-cli/src/main.rs 88.03% <100.00%> (ø)
crates/pop-cli/src/commands/mod.rs 70.17% <50.00%> (ø)
crates/pop-cli/src/commands/new/chain.rs 46.17% <60.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ical10 ical10 force-pushed the husni/fix-chain-command branch from 884b353 to b4c984e Compare July 20, 2025 14:11
@ical10
Copy link
Contributor Author

ical10 commented Jul 20, 2025

Hey @Daanvdplas , I have resolved all of the reviews.

@Daanvdplas
Copy link
Collaborator

Daanvdplas commented Jul 21, 2025

@ical10 the CI seems to fail, would you be interested to check what is going wrong? From a quick check it seems that we are trying to use the parachain feature in the CI which now has been changed to chain

@ical10
Copy link
Contributor Author

ical10 commented Jul 21, 2025

Hey @Daanvdplas , I've modified the features in CI. There were some formatting errors which I've fixed too.

@ical10
Copy link
Contributor Author

ical10 commented Jul 21, 2025

Hopefully the CI is happy now :)

AlexD10S
AlexD10S reviewed Jul 23, 2025
View reviewed changes
Copy link
Collaborator

@AlexD10S AlexD10S left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Refactoring across such a large codebase is no easy task, and you've done an impressive job here.

I've left a few comments, nothing critical, but worth addressing before merge.

After this is merge, I'll update the documentation learn.onpop.io/chains to reflect the changes introduced in this PR.

@AlexD10S AlexD10S mentioned this pull request Jul 24, 2025
Closed
@AlexD10S
Copy link
Collaborator

AlexD10S commented Jul 28, 2025

Once you merge the main branch after the fix #577 , the CI should go green.

@ical10
Copy link
Contributor Author

ical10 commented Jul 28, 2025

Hi @AlexD10S , thanks for the reviews!

I'm quite busy with other stuff but I will try to push some fixes this week. Hope it's okay.

@AlexD10S
Copy link
Collaborator

AlexD10S commented Jul 29, 2025

Hi @AlexD10S , thanks for the reviews!

I'm quite busy with other stuff but I will try to push some fixes this week. Hope it's okay.

Of course, no worries at all. Let me know if anything’s unclear or if I can help with something, I’d be happy to assist. Really appreciate your contribution!

@AlexD10S AlexD10S mentioned this pull request Jul 29, 2025
Merged
@ical10 ical10 force-pushed the husni/fix-chain-command branch from 167eb21 to 3cf7d62 Compare July 30, 2025 11:47
@ical10 ical10 requested a review from AlexD10S July 30, 2025 12:01
@ical10
Copy link
Contributor Author

ical10 commented Jul 30, 2025

Hi @AlexD10S , seems like the coverage test was running for a while, then got cancelled instead of failed.

Is there something to fix on my end?

@AlexD10S
Copy link
Collaborator

AlexD10S commented Jul 31, 2025

Hi @AlexD10S , seems like the coverage test was running for a while, then got cancelled instead of failed.

Is there something to fix on my end?

No, is something in our end. But I can see the tests are passing

AlexD10S
AlexD10S approved these changes Jul 31, 2025
View reviewed changes
Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this contribution.

@AlexD10S AlexD10S merged commit 8c83548 into r0gue-io:main Jul 31, 2025
57 of 61 checks passed
@AlexD10S AlexD10S mentioned this pull request Aug 12, 2025
Closed
@Daanvdplas
Copy link
Collaborator

Daanvdplas commented Aug 13, 2025

He @ical10, again thanks for the contribution!

Do you have any feedback for us? We want others to feel welcomed and enjoy to contribute to the project :)

@ical10
Copy link
Contributor Author

ical10 commented Aug 13, 2025

Hey @Daanvdplas , I have no complaints here, I feel very welcomed and supported. That's very nice.

I hope that my contribution is worthwhile and wish to be able to contribute again soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Daanvdplas Daanvdplas Daanvdplas left review comments

@AlexD10S AlexD10S AlexD10S approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix: inconsistent parachain and chain usage in commands

3 participants

@ical10 @Daanvdplas @AlexD10S