Skip to content

fix(ci): address failing unit tests and cargo-deny issues #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chungquantin merged 2 commits into from
Jun 26, 2025
Merged

fix(ci): address failing unit tests and cargo-deny issues #548

chungquantin merged 2 commits into from
Jun 26, 2025

Conversation

@AlexD10S
Copy link
Collaborator

@AlexD10S AlexD10S commented Jun 25, 2025

This PR fixes CI job failures affecting some open PRs. Specifically:

@AlexD10S AlexD10S requested review from al3mart and chungquantin June 25, 2025 09:19
@codecov
Copy link

codecov bot commented Jun 25, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.34%. Comparing base (92b9d02) to head (a8061fa).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/pop-cli/src/commands/up/mod.rs 0.00% 0 Missing and 1 partial ⚠️ 
@@           Coverage Diff           @@
##             main     #548   +/-   ##
=======================================
  Coverage   79.34%   79.34%           
=======================================
  Files         106      106           
  Lines       25828    25828           
  Branches    25828    25828           
=======================================
  Hits        20494    20494           
  Misses       3047     3047           
  Partials     2287     2287
Files with missing lines Coverage Δ
crates/pop-cli/src/commands/call/chain.rs 76.73% <ø> (ø)
crates/pop-cli/src/commands/call/contract.rs 80.45% <ø> (ø)
...rates/pop-cli/src/commands/test/create_snapshot.rs 59.80% <ø> (ø)
crates/pop-cli/src/commands/up/rollup.rs 71.53% <ø> (ø)
crates/pop-cli/src/common/chain.rs 73.52% <ø> (ø)
crates/pop-cli/src/common/try_runtime.rs 92.06% <ø> (ø)
crates/pop-common/src/metadata.rs 94.62% <ø> (ø)
crates/pop-contracts/src/call.rs 73.88% <ø> (ø)
crates/pop-contracts/src/up.rs 67.00% <ø> (ø)
crates/pop-parachains/src/call/mod.rs 58.57% <ø> (ø)
... and 1 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AlexD10S AlexD10S mentioned this pull request Jun 25, 2025
Merged
@chungquantin chungquantin merged commit 2e84ba9 into main Jun 26, 2025
23 of 24 checks passed
@chungquantin chungquantin deleted the fix/ci branch June 26, 2025 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@al3mart al3mart Awaiting requested review from al3mart

1 more reviewer

@chungquantin chungquantin chungquantin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AlexD10S @chungquantin