feat(bench/pallet): support benchmarking multiple pallets #547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chungquantin
commented
Jun 24, 2025
chungquantin
changed the title
chungquantin
force-pushed
the
chungquantin/feat-multiple_pallets_benchmarking
branch
from
e072fe9 to
4fb13c0
Compare
AlexD10S
reviewed
Jun 26, 2025
Collaborator
There was a problem hiding this comment.
The update_excluded_extrinsics_works unit test is failing: https://github.com/r0gue-io/pop-cli/actions/runs/15891493397/job/44815303172
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #547 +/- ##
==========================================
+ Coverage 79.34% 79.36% +0.01%
==========================================
Files 106 106
Lines 25828 25979 +151
Branches 25828 25979 +151
==========================================
+ Hits 20494 20619 +125
- Misses 3047 3073 +26
Partials 2287 2287
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
AlexD10S
approved these changes
Jun 30, 2025
Collaborator
AlexD10S
left a comment
AlexD10S
left a comment
There was a problem hiding this comment.
Great! Thanks for fixing it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR introduces a new feature to benchmark multiple pallets and exclude extrinsics from benchmarking. Applying changes made to
frame-omni-bencher v0.11.1inpolkadot-sdk: paritytech/polkadot-sdk#8265--palletsoption to selectively run multiple pallets. In the past we only had--palletto run a single one.--exclude-extrinsics [pallet::extrinsic]to add (Pallet,Extrinsic) tuples that should be excluded.How to test the feature?
Run the below command to test: