-
Notifications
You must be signed in to change notification settings - Fork 40
test(cli/try-runtime): update pallets in try-state test after runtime upgrade #543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #543 +/- ##
=======================================
Coverage 78.69% 78.69%
=======================================
Files 101 101
Lines 23922 23924 +2
Branches 23922 23924 +2
=======================================
+ Hits 18825 18827 +2
Misses 2886 2886
Partials 2211 2211
🚀 New features to boost your workflow:
|
chungquantin
approved these changes
May 29, 2025
Contributor
chungquantin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix.
evilrobot-01
added a commit
that referenced
this pull request
May 29, 2025
…iles (#523) * refactor(up): use positional argument for network config file * docs: add broken intra doc links override for deprecated command * build(deps): bump zombienet-sdk version * refactor: network config * refactor: update versions * test(parachains): update integration tests after parameter type change * test(cli): update integration tests after usage change * docs(cli): update example usage after parameter change * chore: update examples after usage change * feat: add support for launching networks without network config files * refactor: resolve feature-related compilation issues * docs: fix doc comments * fix: restore specification of network file via option * fix: ensure min two nodes specified always * docs: fix doc test after parameter change * refactor(cli): ensure distinct set of binaries * refactor(parachains): use relay runtime version when system runtime version not explicitly provided * refactor(parachains): improve support for building node from source * test(cli): improve parachain integration tests Required due to failing within CI workflow. * feat(up): allow specification of port via :port specifier * feat(up): auto-open hrmp channels * feat(up): add default args * refactor(cli): add short version for port arg * feat: para registry * docs(common): resolve intra doc link issue * feat: add westend * refactor: resolve issues after rebase * chore: update cargo.lock * refactor: merge cached binary versions into candidates * feat(cli/up): include endpoint and papi console in output * feat(cli): auto-add missing dependencies * feat(parachains): add genesis overrides * feat(cli): add epoch duration to output * refactor(cli/up): improve log import usage * refactor(cli/up): update deprecation version after recent release * feat(cli): add error function to cli trait/abstraction * refactor(cli/up/network): use cli type for ui * build(deps): update zombienet to latest * refactor: simplify imports * docs(cli): update deprecation comment with correct version * test(common): add sortedslice tests * refactor(common): improve version parsing and sorting * refactor: parachain to rollup * test(common/sourcing): add tagpattern tests * test(common/sourcing): add resolve tests * docs: fix rollup trait reference * test(parachains/up/chain-specs): add conversion tests for maximum coverage * refactor: resolve clippy warnings * test(parachains/registry): add tests * test(parachains/up): add remaining tests * test(parachains/up): improve coverage * refactor(sourcing): improve error type * refactor(sourcing): configurable cache filtering during resolution * fix(cli/call): skip sudo prompt when using skip_confirm * test(cli/parachain): resolve integration test issues * refactor(common/source): address clippy warning * test(parachains/up): remove printlns * test(cli/parachains): restore temp working directory * docs: improve comment Co-authored-by: Tin Chung <[email protected]> * refactor(up/network): improve output Co-authored-by: Tin Chung <[email protected]> * docs: improve description Co-authored-by: Tin Chung <[email protected]> * docs: improve comment Co-authored-by: Tin Chung <[email protected]> * docs: improve comment Co-authored-by: Tin Chung <[email protected]> * docs: fix comment Co-authored-by: Tin Chung <[email protected]> * docs: improve comment Co-authored-by: Tin Chung <[email protected]> * build(deps): bump zombienet * refactor(common/sourcing): restructure cached file check to improve legibility * refactor(parachains/up): add relay.rollups convenience function * test(cli): align comment with command * refactor(parachains/up): resolve clippy warning * refactor(source): introduce archivefilespec struct for defining required archive contents refactor(sourcing): introduce archivefilespec struct for defining required archive contents * test(cli/try-runtime): update pallets in try-state test after runtime upgrade (#543) (cherry picked from commit 80b7c22) --------- Co-authored-by: Tin Chung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list of pallets on the live network changed recently, causing a try-state test to fail.
Ideally that test should be rewritten to run against a local node/mock, but that it beyond the current requirements to fix CI, which is preventing other PRs from being merged.
[sc-3794]