Skip to content

Conversation

@evilrobot-01
Copy link
Contributor

@evilrobot-01 evilrobot-01 commented May 29, 2025

The list of pallets on the live network changed recently, causing a try-state test to fail.

Ideally that test should be rewritten to run against a local node/mock, but that it beyond the current requirements to fix CI, which is preventing other PRs from being merged.

[sc-3794]

@chungquantin chungquantin self-requested a review May 29, 2025 09:41
@codecov
Copy link

codecov bot commented May 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.69%. Comparing base (30763a9) to head (6548710).
Report is 1 commits behind head on main.

@@           Coverage Diff           @@
##             main     #543   +/-   ##
=======================================
  Coverage   78.69%   78.69%           
=======================================
  Files         101      101           
  Lines       23922    23924    +2     
  Branches    23922    23924    +2     
=======================================
+ Hits        18825    18827    +2     
  Misses       2886     2886           
  Partials     2211     2211           
Files with missing lines Coverage Δ
crates/pop-cli/src/common/try_runtime.rs 92.06% <100.00%> (+0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@chungquantin chungquantin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@chungquantin chungquantin merged commit 80b7c22 into main May 29, 2025
28 of 29 checks passed
@chungquantin chungquantin deleted the frank/test-try-state branch May 29, 2025 09:59
evilrobot-01 added a commit that referenced this pull request May 29, 2025
evilrobot-01 added a commit that referenced this pull request May 29, 2025
…iles (#523)

* refactor(up): use positional argument for network config file

* docs: add broken intra doc links override for deprecated command

* build(deps): bump zombienet-sdk version

* refactor: network config

* refactor: update versions

* test(parachains): update integration tests after parameter type change

* test(cli): update integration tests after usage change

* docs(cli): update example usage after parameter change

* chore: update examples after usage change

* feat: add support for launching networks without network config files

* refactor: resolve feature-related compilation issues

* docs: fix doc comments

* fix: restore specification of network file via option

* fix: ensure min two nodes specified always

* docs: fix doc test after parameter change

* refactor(cli): ensure distinct set of binaries

* refactor(parachains): use relay runtime version when system runtime version not explicitly provided

* refactor(parachains): improve support for building node from source

* test(cli): improve parachain integration tests

Required due to failing within CI workflow.

* feat(up): allow specification of port via :port specifier

* feat(up): auto-open hrmp channels

* feat(up): add default args

* refactor(cli): add short version for port arg

* feat: para registry

* docs(common): resolve intra doc link issue

* feat: add westend

* refactor: resolve issues after rebase

* chore: update cargo.lock

* refactor: merge cached binary versions into candidates

* feat(cli/up): include endpoint and papi console in output

* feat(cli): auto-add missing dependencies

* feat(parachains): add genesis overrides

* feat(cli): add epoch duration to output

* refactor(cli/up): improve log import usage

* refactor(cli/up): update deprecation version after recent release

* feat(cli): add error function to cli trait/abstraction

* refactor(cli/up/network): use cli type for ui

* build(deps): update zombienet to latest

* refactor: simplify imports

* docs(cli): update deprecation comment with correct version

* test(common): add sortedslice tests

* refactor(common): improve version parsing and sorting

* refactor: parachain to rollup

* test(common/sourcing): add tagpattern tests

* test(common/sourcing): add resolve tests

* docs: fix rollup trait reference

* test(parachains/up/chain-specs): add conversion tests for maximum coverage

* refactor: resolve clippy warnings

* test(parachains/registry): add tests

* test(parachains/up): add remaining tests

* test(parachains/up): improve coverage

* refactor(sourcing): improve error type

* refactor(sourcing): configurable cache filtering during resolution

* fix(cli/call): skip sudo prompt when using skip_confirm

* test(cli/parachain): resolve integration test issues

* refactor(common/source): address clippy warning

* test(parachains/up): remove printlns

* test(cli/parachains): restore temp working directory

* docs: improve comment

Co-authored-by: Tin Chung <[email protected]>

* refactor(up/network): improve output

Co-authored-by: Tin Chung <[email protected]>

* docs: improve description

Co-authored-by: Tin Chung <[email protected]>

* docs: improve comment

Co-authored-by: Tin Chung <[email protected]>

* docs: improve comment

Co-authored-by: Tin Chung <[email protected]>

* docs: fix comment

Co-authored-by: Tin Chung <[email protected]>

* docs: improve comment

Co-authored-by: Tin Chung <[email protected]>

* build(deps): bump zombienet

* refactor(common/sourcing): restructure cached file check to improve legibility

* refactor(parachains/up): add relay.rollups convenience function

* test(cli): align comment with command

* refactor(parachains/up): resolve clippy warning

* refactor(source): introduce archivefilespec struct for defining required archive contents

refactor(sourcing): introduce archivefilespec struct for defining required archive contents

* test(cli/try-runtime): update pallets in try-state test after runtime upgrade (#543)

(cherry picked from commit 80b7c22)

---------

Co-authored-by: Tin Chung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants