Skip to content

Conversation

@evilrobot-01
Copy link
Contributor

Fixes the current failing test by updating the expected value.

@chungquantin chungquantin self-requested a review May 16, 2025 10:16
@codecov
Copy link

codecov bot commented May 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.68%. Comparing base (1c4797d) to head (8c2e867).
Report is 1 commits behind head on main.

@@            Coverage Diff             @@
##             main     #539      +/-   ##
==========================================
- Coverage   78.68%   78.68%   -0.01%     
==========================================
  Files         101      101              
  Lines       23927    23926       -1     
  Branches    23927    23926       -1     
==========================================
- Hits        18828    18827       -1     
  Misses       2885     2885              
  Partials     2214     2214              
Files with missing lines Coverage Δ
crates/pop-parachains/src/bench/mod.rs 88.40% <100.00%> (-0.06%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@chungquantin chungquantin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@evilrobot-01 evilrobot-01 merged commit 343cd42 into main May 19, 2025
37 of 38 checks passed
@evilrobot-01 evilrobot-01 deleted the frank/fix-benchmarking-test branch May 19, 2025 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants