Skip to content

Conversation

@AlexD10S
Copy link
Collaborator

@AlexD10S AlexD10S commented May 7, 2025

  • Update crate versions to 0.8.0.
  • Update Changelog file. Run git cliff --bump
  • Remove Deprecated flags introduced 2 releases ago:
    - Remove pop test contract, it works only with pop test.
    - Remove pop up contract, it works only with pop up.
    - Remove pop test parachain, it works only with pop up.

Note: The endpoint wss://rpc1.paseo.popnetwork.xyz is currently down, which was causing test failures. To ensure the CI passes before the release, the URL has been replaced with wss://rpc2.paseo.popnetwork.xyz.
To prevent similar issues in the future, some tests has to be migrated to integration tests that run against a local node. See: #535

@AlexD10S AlexD10S force-pushed the chore/release-v0.8.0 branch from 9c45701 to 551e456 Compare May 7, 2025 17:24
@AlexD10S AlexD10S force-pushed the chore/release-v0.8.0 branch from 551e456 to e481be7 Compare May 7, 2025 17:37
@codecov
Copy link

codecov bot commented May 7, 2025

Codecov Report

Attention: Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.68%. Comparing base (9999726) to head (c264d35).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/pop-cli/src/commands/mod.rs 85.71% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main     #536      +/-   ##
==========================================
- Coverage   79.11%   78.68%   -0.43%     
==========================================
  Files         101      101              
  Lines       23785    23925     +140     
  Branches    23785    23925     +140     
==========================================
+ Hits        18818    18826       +8     
- Misses       2745     2886     +141     
+ Partials     2222     2213       -9     
Files with missing lines Coverage Δ
crates/pop-cli/src/commands/call/chain.rs 76.80% <100.00%> (ø)
crates/pop-cli/src/commands/call/contract.rs 80.45% <100.00%> (-0.51%) ⬇️
...rates/pop-cli/src/commands/test/create_snapshot.rs 59.80% <ø> (-30.40%) ⬇️
crates/pop-cli/src/commands/test/mod.rs 74.69% <ø> (-0.31%) ⬇️
crates/pop-cli/src/commands/up/contract.rs 36.60% <ø> (-4.36%) ⬇️
crates/pop-cli/src/commands/up/mod.rs 82.53% <ø> (-0.67%) ⬇️
crates/pop-cli/src/commands/up/network.rs 6.97% <ø> (+0.15%) ⬆️
crates/pop-cli/src/commands/up/rollup.rs 71.53% <ø> (ø)
crates/pop-cli/src/common/chain.rs 73.52% <ø> (ø)
crates/pop-cli/src/common/try_runtime.rs 92.04% <ø> (ø)
... and 3 more

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@evilrobot-01 evilrobot-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. The fixes around the rpc used should be their own PR in my view, as they do not align with the title of this PR.

Copy link
Contributor

@chungquantin chungquantin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only left a few nitpicks. Happy to approve after.

@AlexD10S AlexD10S requested review from chungquantin and evilrobot-01 and removed request for Daanvdplas, chungquantin and evilrobot-01 May 8, 2025 08:07
@chungquantin chungquantin self-requested a review May 8, 2025 09:00
Copy link
Contributor

@chungquantin chungquantin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!

@AlexD10S AlexD10S requested a review from evilrobot-01 May 8, 2025 10:54
@AlexD10S AlexD10S merged commit 69d3310 into main May 8, 2025
23 of 24 checks passed
@AlexD10S AlexD10S deleted the chore/release-v0.8.0 branch May 8, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants