fix: separate runtime binary path and project path #531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chungquantin
force-pushed
the
chungquantin/fix-runtime_path
branch
from
51ddedd to
bbe6be5
Compare
chungquantin
changed the title
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #531 +/- ##
==========================================
+ Coverage 78.78% 78.92% +0.13%
==========================================
Files 99 100 +1
Lines 23186 23513 +327
Branches 23186 23513 +327
==========================================
+ Hits 18268 18558 +290
- Misses 2719 2743 +24
- Partials 2199 2212 +13
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
AlexD10S
approved these changes
Apr 25, 2025
Collaborator
AlexD10S
left a comment
AlexD10S
left a comment
There was a problem hiding this comment.
Looks great! Nothing to add — LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #519
Description
Instead of returning the path to the runtime WASM binary
.wasm, we return the runtime project path. For example, ifpop-node/runtime/testnetis selected or inputted, it is returned in the single command output or the.benchfile as:--runtime=pop-node/runtime/testnet. Then when running the command, runtime project can be located and rebuilt. If.wasmfile is provided, the build process is skipped.Output the relative path of the runtime project in
.benchfile and the single command outputBefore
After
How to test the PR?
pop-nodepop bench palletpop-bench.tomlpop-bench.tomlto find the runtime project path is saved inruntime=pop bench pallet -f pop-bench.toml, now runtime project is rebuilt.