chore: update required version of the frame-omni-bencher binary #527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #527 +/- ##
==========================================
- Coverage 78.78% 78.78% -0.01%
==========================================
Files 99 99
Lines 23186 23184 -2
Branches 23186 23184 -2
==========================================
- Hits 18268 18266 -2
+ Misses 2719 2718 -1
- Partials 2199 2200 +1
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
AlexD10S
reviewed
Apr 21, 2025
AlexD10S
approved these changes
Apr 21, 2025
Collaborator
AlexD10S
left a comment
AlexD10S
left a comment
There was a problem hiding this comment.
Thanks for addressing the feedback so quickly. LGTM ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the version tests of the binaries
frame-omni-bencherandtry-runtime. The idea is, whatever versions above the threshold one are accepted and source binaries if the deprecated version of the binaries used.If there is a break in the future version of the binary, we update the threshold version and change the code to support newer versions.