Codecov Report

Attention: Patch coverage is 80.19276% with 596 lines in your changes missing coverage. Please review.

Project coverage is 79.34%. Comparing base (30763a9) to head (97c31bf).
Report is 2 commits behind head on main.

@@            Coverage Diff             @@
##             main     #523      +/-   ##
==========================================
+ Coverage   78.69%   79.34%   +0.65%     
==========================================
  Files         101      106       +5     
  Lines       23922    25828    +1906     
  Branches    23922    25828    +1906     
==========================================
+ Hits        18825    20494    +1669     
- Misses       2886     3047     +161     
- Partials     2211     2287      +76     

It also opens the door to building a more interactive setup guide or UI, which could really help newcomers onboard more smoothly.

I'm not sure it warrants a UI tbh, at least not anytime soon. A UI makes sense for some contexts (e.g. call, where there are many possible calls and many parameters), but slapping a UI on something for the sake of it, when it can be improved to be simpler and therefore more powerful has more value. I would personally rather use shell history/auto-completes with simple commands, than be confronted with a complex UI that I need to interact with for a few minutes each time.

I noticed that in the code you’re introducing the term Parachain again for new structs and methods. Do you think this could be refactored or renamed after the inital refactored we started a month ago.

As discussed separately, will refactor to use 'rollup'.

Just a couple of minor nitpicks:
* The description example: pop up kusama --port 8833 --parachain asset-hub:9977,pop:9944 doesn't seem to work. Running pop up kusama --help shows that pop isn’t listed as a supported parachain:

This is intentional. There is no deployment on Kusama, there is no reserved para on Kusama, there is no runtime specifically targeting Kusama. I updated the example commands in the PR description to remove pop from the kusama example.

* The `#id:port` format (e.g., `asset-hub#1000:9944`) could be a bit confusing for newcomers. 

Perhaps, but anyone that has familiarity with urls should know that ports are specified via :port and fragment identifiers via #hash. This general approach is already used in

Edit: I have a few concerns on how the command can be used here: Based on the example usage:

pop up paseo -p asset-hub,pop -r stable2412-4
pop up kusama --port 8833 --parachain asset-hub:9944 -r stable2412-4
pop up polkadot --port 8833 --parachain asset-hub:9977,pop#3395:9944 -r stable2412-4
pop up westend -p asset-hub

Would it be cleaner to follow the below command design?

pop up --relay kusama:8833 --para asset-hub:9944 -r stable2412-4

Here we can keep it consistent between the relaychain parameter and parachain parameter. And no new commands introduced. (I know it breaks the overall design of the PR but just something to consider imo).

Technically it would be pop up network --relay kusama:8833 --para asset-hub:9944 -r stable2412-4, which is considerably more verbose. The goal of this PR was to make it short and simple. You need a relay on every launch, so why define it as an option/arg? What does --relay kusama bring that is better than pop up kusama besides more typing? The only benefit I can see here is specifying the relay port in a consistent manner which is tempting. The next issue however is now the clash with the existing network subcommand which expects a file, as now we are specifying a file and also specifying a relay and chains. In order to not break that existing subcommand, we would therefore need to introduce a new subcommand, which is what we already have with each of the supported relay subcommands.

Another point is the -r tag, why not -v tag for the version?

pop up kusama --port 8833 --parachain asset-hub:9944 -v stable2412-4

if you look at the existing options for pop up network, you will see there are a number of versions than can be specified (relay binary, relay runtime, system parachain binary, system parachain runtime) so there needs to be more than just -v. This is just the nature of Polkadot.