test: no default features #522
Conversation
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #522 +/- ##
==========================================
+ Coverage 79.06% 79.08% +0.02%
==========================================
Files 101 101
Lines 23689 23724 +35
Branches 23689 23724 +35
==========================================
+ Hits 18729 18763 +34
- Misses 2742 2743 +1
Partials 2218 2218
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
AlexD10S
left a comment
AlexD10S
left a comment
There was a problem hiding this comment.
Although this isn't introduced in this PR, I ran into errors when executing:
cargo test --lib --bins --no-default-features --features contract
or
cargo test --lib --bins --no-default-features --features parachain
Looks like there are some errors with the dependencies when running with individual features. Might be worth fixing that up and updating the CI to test individual features instead of:
- name: Run unit tests
run: cargo test --lib --bins
evilrobot-01
force-pushed
the
frank/test-no-default-features
branch
from
2b4987f to
b30b596
Compare
evilrobot-01
force-pushed
the
frank/test-no-default-features
branch
from
b30b596 to
db00599
Compare
|
Rebased on main, resolving conflict |
evilrobot-01
force-pushed
the
frank/test-no-default-features
branch
from
d8bc3a5 to
5d433ca
Compare
|
Rebased on main after ci test issue resolved. |
|
428a89a exposes the github token to those specific steps which need it only. It is already used in the CI at pop-cli/.github/workflows/ci.yml Line 76 in 23c7b82 Additional context:
https://docs.github.com/en/actions/security-for-github-actions/security-guides/automatic-token-authentication#example-2-calling-the-rest-api also shows it being used in the same way as used within the |
A follow up to #520, ensuring that tests can be run successfully with no/default/all features enabled. Also updates CI workflow to check these cases.
Note: ideally implementations should be refactored into separate tests depending on feature where practical, instead of sprinkling
#[cfg(feature = "xx")]throughout. Hopefully this will come about organically over time now that the additional test checks are added to the CI workflow.