Skip to content

Conversation

@evilrobot-01
Copy link
Contributor

@evilrobot-01 evilrobot-01 commented Apr 9, 2025

Addresses all issues reported by cargo doc and then also adds missing docs for public items.

[sc-3576]

@codecov
Copy link

codecov bot commented Apr 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.78%. Comparing base (6862c4a) to head (f0804a7).
Report is 3 commits behind head on main.

@@            Coverage Diff             @@
##             main     #521      +/-   ##
==========================================
- Coverage   78.89%   78.78%   -0.11%     
==========================================
  Files          99       99              
  Lines       23146    23186      +40     
  Branches    23146    23186      +40     
==========================================
+ Hits        18260    18268       +8     
- Misses       2687     2719      +32     
  Partials     2199     2199              
Files with missing lines Coverage Δ
crates/pop-cli/src/commands/mod.rs 68.66% <ø> (-7.00%) ⬇️
crates/pop-cli/src/commands/new/mod.rs 100.00% <ø> (ø)
crates/pop-cli/src/commands/test/mod.rs 72.00% <ø> (-5.15%) ⬇️
crates/pop-cli/src/commands/up/mod.rs 82.81% <ø> (ø)
crates/pop-cli/src/commands/up/network.rs 6.81% <ø> (ø)
crates/pop-cli/src/common/contracts.rs 79.79% <ø> (ø)
crates/pop-cli/src/main.rs 88.03% <ø> (+4.96%) ⬆️
crates/pop-common/src/git.rs 76.62% <ø> (ø)
crates/pop-common/src/lib.rs 74.50% <ø> (ø)
crates/pop-common/src/polkadot_sdk.rs 95.00% <ø> (ø)
... and 9 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@evilrobot-01 evilrobot-01 requested a review from AlexD10S April 9, 2025 12:57
@evilrobot-01 evilrobot-01 marked this pull request as ready for review April 9, 2025 13:06
Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for taking this. Some of these were necessary and had been pending for a while.

Closes #364

@evilrobot-01 evilrobot-01 merged commit 5af36d3 into main Apr 9, 2025
20 of 21 checks passed
@evilrobot-01 evilrobot-01 deleted the frank/docs branch April 9, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants