build(deps): eliminate unnecessary dependencies #520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
April 8, 2025 16:26
Makes the dependency tree somewhat explicit.
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #520 +/- ##
==========================================
- Coverage 78.89% 78.78% -0.11%
==========================================
Files 99 99
Lines 23146 23186 +40
Branches 23146 23186 +40
==========================================
+ Hits 18260 18268 +8
- Misses 2687 2719 +32
Partials 2199 2199
🚀 New features to boost your workflow:
|
added 5 commits
April 8, 2025 20:44
Ensures warnings are addressed before merge.
AlexD10S
approved these changes
Apr 9, 2025
Collaborator
AlexD10S
left a comment
AlexD10S
left a comment
There was a problem hiding this comment.
Thanks for the cleanup!
Everything looks good to me, I just left a couple of minor comments suggesting the addition of documentation comments for public modules. Good to go after that!
Contributor
Author
|
Docs require some love. As this PR is only about resolving the dependencies, my suggestion is to tackle the docs separately and holistically in a single PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminates unnecessary dependencies when building without default features. The number of dependencies when building with the
contractfeature only has been halved from ~1k to 500k. A handful were removed more generally by usingdefault-features = false.Also updates CI to ensure that builds with -
-no-default-featuresare successful and remain so. Whilst the tool is primarily aimed towards contract and parachain development, allowing successful builds with no default features allows the introduction and testing of additional experimental features which are not specific to these two developer journeys.[sc-3569]