chore: source remote binary if version not matches #516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
crates/pop-cli/src/common/binary.rs:178
- [nitpick] The test 'semantic_version_invalid_works' uses non-version strings ('bash', 'which') to test version parsing, which might not effectively validate the SemanticVersion conversion logic. Consider using controlled version strings to ensure the test accurately reflects expected behavior.
fn semantic_version_invalid_works() {
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #516 +/- ##
==========================================
+ Coverage 78.36% 78.93% +0.56%
==========================================
Files 95 98 +3
Lines 22339 22863 +524
Branches 22339 22863 +524
==========================================
+ Hits 17507 18046 +539
+ Misses 2680 2659 -21
- Partials 2152 2158 +6
... and 20 files with indirect coverage changes 🚀 New features to boost your workflow:
|
AlexD10S
approved these changes
Apr 7, 2025
Collaborator
AlexD10S
left a comment
AlexD10S
left a comment
There was a problem hiding this comment.
I test it with:
cargo install --git https://github.com/paritytech/try-runtime-cli --tag v0.7.0 --locked
And then running pop test on-runtime-upgrade it sources the lastest version:
◇ ✅ try-runtime successfully sourced. Cached at: /Users/alexbean/Library/Caches/pop/try-runtime-cli-v0.8.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SemanticVersionto represent to the semantic version(minor, major, patch)which_versionthat returns the path to the binary if the version matches the targeted one.