fix: benchmarking logger #513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #513 +/- ##
==========================================
- Coverage 78.84% 78.77% -0.08%
==========================================
Files 99 99
Lines 23060 23081 +21
Branches 23060 23081 +21
==========================================
Hits 18181 18181
- Misses 2690 2711 +21
Partials 2189 2189
🚀 New features to boost your workflow:
|
chungquantin
force-pushed
the
chungquantin/fix_logger
branch
from
220bbe4 to
fa9daa3
Compare
* feat: canonical command names * refactor: use types in stead of strings * refactor: telemetry * fixes * review * fix: telemetry test * fix: test, clippy * refactor: try runtime * fmt
* chore: bump versions * chore: update CHANGELOG * chore: remove deprecated flag
* feat: pop build runtime * fix: test * chore: reformat * chore: feature gating * chore: add test for collect features * feat: select runtime if multiple * chore: resolve review comments * chore: fix cargo deny * chore: clippy warnings * fix: cargo deny
AlexD10S
approved these changes
Apr 7, 2025
Collaborator
AlexD10S
left a comment
AlexD10S
left a comment
There was a problem hiding this comment.
Thanks for the fix! I can now see the correct output when running pop up network -f ./network.toml, and the status still shows up properly when generating weights with pop bench pallet. Nicely done!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initializing the logger in a global scope is not a good approach. Instead, I initialize a new logger on each new command.