Skip to content

Conversation

@Daanvdplas
Copy link
Collaborator

When the user doesn't want to make changes to the spec that it provides, no prompt for the default bootnode.

Closes #444

@codecov
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

Attention: Patch coverage is 90.62500% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.14%. Comparing base (99c2b0c) to head (cebcfa2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/pop-cli/src/commands/build/spec.rs 90.62% 0 Missing and 3 partials ⚠️
@@            Coverage Diff             @@
##             main     #482      +/-   ##
==========================================
+ Coverage   75.12%   75.14%   +0.01%     
==========================================
  Files          70       70              
  Lines       14967    14997      +30     
  Branches    14967    14997      +30     
==========================================
+ Hits        11244    11269      +25     
- Misses       2252     2254       +2     
- Partials     1471     1474       +3     
Files with missing lines Coverage Δ
crates/pop-cli/src/commands/build/spec.rs 72.49% <90.62%> (+0.59%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@AlexD10S AlexD10S merged commit e99c153 into main Mar 23, 2025
20 checks passed
@AlexD10S AlexD10S deleted the daan/fix-bootnode_prompt branch March 23, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: cli prompt for bootnode even if a chain spec is provided and no changes desired.

3 participants