fix: improve build spec error messaging #477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #477 +/- ##
==========================================
+ Coverage 75.11% 75.18% +0.06%
==========================================
Files 70 71 +1
Lines 14967 15053 +86
Branches 14967 15053 +86
==========================================
+ Hits 11243 11318 +75
- Misses 2253 2255 +2
- Partials 1471 1480 +9
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
chungquantin
suggested changes
Mar 21, 2025
Contributor
chungquantin
left a comment
chungquantin
left a comment
There was a problem hiding this comment.
Seems this PR's issue is already handled in the benchmarking. As benchmarking is not merged to main yet, my suggestion is to have a common method that can be used for both features and then I'll refactor the benchmarking feature after it is merged to main.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the error message when building specs fails, making it clearer and more aligned with the output of the underlying command.
Before:
Running
pop build spec --chain ./wrong-chain-spec:This error message was not very informative and did not clearly indicate the root cause of the failure.
Now:
This message explicitly states the failure reason and matches the output of the underlying command:
Closes #475
[sc-3371]