Skip to content

Conversation

@AlexD10S
Copy link
Collaborator

@AlexD10S AlexD10S commented Mar 9, 2025

After the updates in the pop-node release, one test was failing in the CI (https://github.com/r0gue-io/pop-cli/actions/runs/13666853327/job/38359250240?pr=435) due to a hardcoded value for the node name, pop-devnet which is no longer applicable in the new release. The hardcoded value has been removed.

Additionally, this update fixes cargo deny in the CI by bumping dependency versions. It was automatic done by the dependabot #447. But deny was still failing so had to add a vulnerability in the deny.toml.

The PR introduces two new vulnerability dependency:

@AlexD10S AlexD10S requested a review from chungquantin March 9, 2025 19:19
@codecov
Copy link

codecov bot commented Mar 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.45%. Comparing base (8492820) to head (bc0acf2).
Report is 2 commits behind head on main.

@@            Coverage Diff             @@
##             main     #448      +/-   ##
==========================================
- Coverage   75.46%   75.45%   -0.01%     
==========================================
  Files          64       64              
  Lines       14108    14107       -1     
  Branches    14108    14107       -1     
==========================================
- Hits        10647    10645       -2     
- Misses       2099     2100       +1     
  Partials     1362     1362              
Files with missing lines Coverage Δ
crates/pop-parachains/src/build.rs 88.15% <ø> (-0.03%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@chungquantin chungquantin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@AlexD10S AlexD10S merged commit 1b7d60e into main Mar 10, 2025
19 of 20 checks passed
@AlexD10S AlexD10S deleted the fix/ci-hardcoded-test branch March 10, 2025 07:45
chungquantin added a commit that referenced this pull request Mar 10, 2025
* fix: remove hardcoded node name in test

* fix: bump versions in Cargo.lock to fix deny

* chore: ignore unmantained vulnerability

* fix: cargo deny unmaintained crate

---------

Co-authored-by: chungquantin <[email protected]>
chungquantin added a commit that referenced this pull request Mar 10, 2025
* fix: remove hardcoded node name in test

* fix: bump versions in Cargo.lock to fix deny

* chore: ignore unmantained vulnerability

* fix: cargo deny unmaintained crate

---------

Co-authored-by: chungquantin <[email protected]>
chungquantin added a commit that referenced this pull request Mar 10, 2025
* fix: remove hardcoded node name in test

* fix: bump versions in Cargo.lock to fix deny

* chore: ignore unmantained vulnerability

* fix: cargo deny unmaintained crate

---------

Co-authored-by: chungquantin <[email protected]>
chungquantin added a commit that referenced this pull request Mar 24, 2025
* fix: remove hardcoded node name in test

* fix: bump versions in Cargo.lock to fix deny

* chore: ignore unmantained vulnerability

* fix: cargo deny unmaintained crate

---------

Co-authored-by: chungquantin <[email protected]>
AlexD10S added a commit that referenced this pull request Mar 25, 2025
* refactor: check binary and prompt

* feat: add binary generator

* feat: update parachain templates (#297)

* feat: include new parachain template and remove old one for Parity

* fix: tests

* fix: order in test

* fix: export PATH

* chore: bump zombienet-sdk version

* fix: remove parity evm

* fix: missing changes

* fix: parse collator and parachain-template-node without path for spawn

* chore: remove set PATH

* refactor: functionality and test

* refactor: prefix for external templates

* fix: deprecate old command for generating parity contracts template

* test: update configure_works test to test new functionality

* test: fix unit tests templates

* fix: show deprecation message and fixes

* docs: improve comments

* refactor: nitpicks in parachain description

* fix: logic for substrate-contracts-node without path in config file

* feat: support v3.0.0 of OpenZeppelin templates

* docs: improve template docs and comments

* test: improve comments for clarity

* fix: support different profiles when path is not specified

* refactor: code improvements

* refactor: improve import

* fix: remove onboard.rs empty file (#433)

* chore: update cargo-deny-action@v2 (#439)

* chore: update cargo-deny-action@v2

* chore: revert cargo.lock and add more ignore

* fix: docker missing toolchain

* chore: revert relay.rs changes

* chore: remove vulnerabilities by upgrade zombienet

* fix: hardcoded test failing in the CI (#448)

* fix: remove hardcoded node name in test

* fix: bump versions in Cargo.lock to fix deny

* chore: ignore unmantained vulnerability

* fix: cargo deny unmaintained crate

---------

Co-authored-by: chungquantin <[email protected]>

* feat: add the filter mode and password to `Cli` (#435)

* feat: add the filter mode to cli

* chore: rebase

* chore: revert cargo.lock and add more ignore

* chore: update cargo-deny-action@v2

* chore: revert relay.rs changes

* chore: remove vulnerabilities by upgrade zombienet

* chore: rebase

* chore: clippy warning

* chore: revert not relevant changes

* chore: add password to the Cli (#449)

* chore: add password input in cli module

* chore: format

---------

Co-authored-by: Alex Bean <[email protected]>

* chore: resolve unmaintained crate & clippy warnings (#454)

* chore: resolve clippy warnings

* fix: unmantained crate

* chore: hard-coded the version of pop-node binary

* chore: fix pop-node CI issue

* feat: register parachain (#404)

* test: detects_project_type_correctly

* feat: parachain deployment in pop up

* fix: parachain feature

* docs: improve comments

* feat: replace index.html with summary costs in ui (#430)

* refactor: rename parachain to rollup

* docs: improve deprecation message

* refactor: rename parachain to rollup in up help

* feat: logic for parachain registration (#410)

* feat: deploy a parachain commands

* feat: build specs in pop up

* feat: logic to interact with a chain

* feat: register parachain

* refactor: clean code and improve docs

* test: unit tests for pop up methods

* refactor: small fixes with visibility and removing logs

* feat: return events in submit_signed_extrinsic

* feat: get para_id from event

* test: fix detects_parachain_correctly

* refactor: improve docs and code

* test: fix change_working_directory_works

* fix: clippy warnings

* refactor: move submit_extrinsic_with_wallet in a common file

* refactor: remove unnecesary code

* refactor: UpChainCommand structure

* test: adjust tests to refactored struct

* refactor: renaming prepare_register_parachain_call_data and prepare_rerve_parachain_call_data

* refactor: move events module

* fix: submit_extrinsic_with_wallet under parachain feature

* refactor: remove unnecesary code

* test: increase coverage with reserve_parachain_id_fails_wrong_chain and resolve_genesis_files_fails_wrong_path

* refactor: remove unnecesary clones

* refactor: minor improvements

* test: refactor tests and include comments

* refactor: map errors in submit_extrinsic_with_wallet

* test: fix prepare_register_parachain_call_data_works

* refactor: move configure_chain into a common folder

* refactor: function visibility

* fix: error message and include test for it

* refactor: build specs removing repetitive code

* refactor: use prepare_extrinsic from Call module to prepare a call

* docs: improve comments and messages

* refactor: rename variables and structs

* refactor: relay_chain_url

* refactor: rename prepare_reserve_call_data and prepare_register_call_data

* test: remove unnecesary test

* refactor: remove events module

* refactor: rename parachain to rollup

* chore: improve succesful message

* chore: change intro title to use rollup

* docs: comments for Reserved event

* refactor: improve readability with chain::configure

* refactor: improve message and clean code

* feat: build deterministic runtime (#425)

* test: detects_project_type_correctly

* feat: parachain deployment in pop up

* fix: parachain feature

* docs: improve comments

* feat: deploy a parachain commands

* feat: build specs in pop up

* feat: logic to interact with a chain

* feat: register parachain

* refactor: clean code and improve docs

* test: unit tests for pop up methods

* refactor: small fixes with visibility and removing logs

* feat: return events in submit_signed_extrinsic

* feat: get para_id from event

* test: fix detects_parachain_correctly

* refactor: improve docs and code

* test: fix change_working_directory_works

* fix: clippy warnings

* refactor: move submit_extrinsic_with_wallet in a common file

* refactor: remove unnecesary code

* refactor: UpChainCommand structure

* test: adjust tests to refactored struct

* refactor: renaming prepare_register_parachain_call_data and prepare_rerve_parachain_call_data

* refactor: move events module

* fix: submit_extrinsic_with_wallet under parachain feature

* refactor: remove unnecesary code

* test: increase coverage with reserve_parachain_id_fails_wrong_chain and resolve_genesis_files_fails_wrong_path

* refactor: remove unnecesary clones

* refactor: minor improvements

* test: refactor tests and include comments

* refactor: map errors in submit_extrinsic_with_wallet

* test: fix prepare_register_parachain_call_data_works

* feat: container_engine to detect container to use

* feat: generate_deterministic_runtime logic

* feat: srtool logic

* feat: build deterministic runtime in build spec command

* feat: update_runtime_code

* test: include tests for updateing code

* refactor: clean unnecesary code

* test: in container_engine

* refactor: docker warning in container_engine

* chore: improve screen messaging

* refactor: use profile picked by the user

* refactor: docs in ContainerEngine and clean prints

* fix: generate_deterministic_runtime parameter

* refactor: rename, improve messages and clean empty lines

* feat: extract package name automatically from runtime dir

* docs: change broken link

* refactor: update srtool_lib crate and remove unnecesary code

* docs: include srtool in Acknowledgements

* refactor: remove unnecesary Error

* test: detects_project_type_correctly

* feat: parachain deployment in pop up

* fix: parachain feature

* docs: improve comments

* feat: replace index.html with summary costs in ui (#430)

* refactor: rename parachain to rollup

* docs: improve deprecation message

* refactor: rename parachain to rollup in up help

* feat: deploy a parachain commands

* feat: build specs in pop up

* feat: logic to interact with a chain

* feat: register parachain

* refactor: clean code and improve docs

* test: unit tests for pop up methods

* refactor: small fixes with visibility and removing logs

* feat: return events in submit_signed_extrinsic

* feat: get para_id from event

* test: fix detects_parachain_correctly

* refactor: improve docs and code

* test: fix change_working_directory_works

* fix: clippy warnings

* refactor: move submit_extrinsic_with_wallet in a common file

* refactor: remove unnecesary code

* refactor: UpChainCommand structure

* test: adjust tests to refactored struct

* refactor: renaming prepare_register_parachain_call_data and prepare_rerve_parachain_call_data

* refactor: move events module

* fix: submit_extrinsic_with_wallet under parachain feature

* refactor: remove unnecesary code

* test: increase coverage with reserve_parachain_id_fails_wrong_chain and resolve_genesis_files_fails_wrong_path

* refactor: remove unnecesary clones

* refactor: minor improvements

* test: refactor tests and include comments

* refactor: map errors in submit_extrinsic_with_wallet

* test: fix prepare_register_parachain_call_data_works

* refactor: move configure_chain into a common folder

* refactor: function visibility

* fix: error message and include test for it

* refactor: build specs removing repetitive code

* refactor: use prepare_extrinsic from Call module to prepare a call

* docs: improve comments and messages

* refactor: rename variables and structs

* refactor: relay_chain_url

* refactor: rename prepare_reserve_call_data and prepare_register_call_data

* test: remove unnecesary test

* refactor: remove events module

* refactor: rename parachain to rollup

* chore: improve succesful message

* chore: change intro title to use rollup

* docs: comments for Reserved event

* chore: always prompt the user to build runtime deterministacally and improve message

* docs: improve and add missing comments

* refactor: clean code to prompt for the package and runtime dir

* docs: improve warning message

* refactor: rename variables and structs

* fix: throw error message when build deterministic runtime fail

* feat: include skip_deterministic_build flag to avoid prompting the user

* docs: improve comments

* feat: use a proxy for the registration (#427)

* test: detects_project_type_correctly

* feat: parachain deployment in pop up

* fix: parachain feature

* docs: improve comments

* feat: deploy a parachain commands

* feat: build specs in pop up

* feat: logic to interact with a chain

* feat: register parachain

* refactor: clean code and improve docs

* test: unit tests for pop up methods

* refactor: small fixes with visibility and removing logs

* feat: return events in submit_signed_extrinsic

* feat: get para_id from event

* test: fix detects_parachain_correctly

* refactor: improve docs and code

* test: fix change_working_directory_works

* fix: clippy warnings

* refactor: move submit_extrinsic_with_wallet in a common file

* refactor: remove unnecesary code

* refactor: UpChainCommand structure

* test: adjust tests to refactored struct

* refactor: renaming prepare_register_parachain_call_data and prepare_rerve_parachain_call_data

* refactor: move events module

* fix: submit_extrinsic_with_wallet under parachain feature

* refactor: remove unnecesary code

* test: increase coverage with reserve_parachain_id_fails_wrong_chain and resolve_genesis_files_fails_wrong_path

* refactor: remove unnecesary clones

* refactor: minor improvements

* test: refactor tests and include comments

* refactor: map errors in submit_extrinsic_with_wallet

* test: fix prepare_register_parachain_call_data_works

* refactor: move configure_chain into a common folder

* refactor: function visibility

* fix: error message and include test for it

* feat: construct_proxy_extrinsic

* feat: prompt for proxy address in the UI

* docs: improve flag description and display command to be executed

* docs: improve prompt to the user message for proxy

* feat: replace index.html with costs for calls with proxy in ui

* refactor: remove display command information (separate PR)

* test: fix resolve_proxy_address_works

* refactor: rename and more clear messages for the user to prompt proxied account

* chore: update index.html with latest changes

* test: fix format

* test: detects_project_type_correctly

* feat: parachain deployment in pop up

* fix: parachain feature

* docs: improve comments

* feat: replace index.html with summary costs in ui (#430)

* refactor: rename parachain to rollup

* docs: improve deprecation message

* refactor: rename parachain to rollup in up help

* feat: deploy a parachain commands

* feat: build specs in pop up

* feat: logic to interact with a chain

* feat: register parachain

* refactor: clean code and improve docs

* test: unit tests for pop up methods

* refactor: small fixes with visibility and removing logs

* feat: return events in submit_signed_extrinsic

* feat: get para_id from event

* test: fix detects_parachain_correctly

* refactor: improve docs and code

* test: fix change_working_directory_works

* fix: clippy warnings

* refactor: move submit_extrinsic_with_wallet in a common file

* refactor: remove unnecesary code

* refactor: UpChainCommand structure

* test: adjust tests to refactored struct

* refactor: renaming prepare_register_parachain_call_data and prepare_rerve_parachain_call_data

* refactor: move events module

* fix: submit_extrinsic_with_wallet under parachain feature

* refactor: remove unnecesary code

* test: increase coverage with reserve_parachain_id_fails_wrong_chain and resolve_genesis_files_fails_wrong_path

* refactor: remove unnecesary clones

* refactor: minor improvements

* test: refactor tests and include comments

* refactor: map errors in submit_extrinsic_with_wallet

* test: fix prepare_register_parachain_call_data_works

* refactor: move configure_chain into a common folder

* refactor: function visibility

* fix: error message and include test for it

* refactor: build specs removing repetitive code

* refactor: use prepare_extrinsic from Call module to prepare a call

* docs: improve comments and messages

* refactor: rename variables and structs

* refactor: relay_chain_url

* refactor: rename prepare_reserve_call_data and prepare_register_call_data

* test: remove unnecesary test

* refactor: remove events module

* refactor: rename parachain to rollup

* chore: improve succesful message

* chore: change intro title to use rollup

* docs: comments for Reserved event

* refactor: clean code to avoid unnecesary clone

* feat: wrap Id by default in the proxy address and improve comment

* refactor: remove ProxyConfig and use Proxy

* refactor: resolve_proxied_address

* fix: change visibility for prompt_for_param

* refactor: more clarity in code variables and comments

* refactor: custom message to prompt for proxy address

* refactor: support only Account Id type for proxied_address

* test: remove unnecesary async in resolve_proxied_address_works

* fix: clippy warnings

* chore: improve deterministic runtime flow (#460)

* chore: hide srtool logs

* chore: include runtime file in the Generated files message

* chore: update with latest index.html

* refactor: small improvements

* refactor: improve the building runtime message

* fix: display events when wallet-signing (#463)

* feat: enable `pop test` without project type specification (#466)

* refactor: test_project to support testing any rust project

* test: unit tests in test mod

* docs: fix pop_contracts test docs

* docs: fix comment in TestCommand error

* refactor: improve docs and visibility

* chore: add doc for macro and test for contracts

* fix: executable permission

---------

Co-authored-by: Alex Bean <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants