fix: increase DefaultBodyLimit to prevent large payload failures
#409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #409 +/- ##
==========================================
+ Coverage 75.11% 75.16% +0.05%
==========================================
Files 63 63
Lines 13842 13870 +28
Branches 13842 13870 +28
==========================================
+ Hits 10398 10426 +28
+ Misses 2118 2117 -1
- Partials 1326 1327 +1
|
peterwht
approved these changes
Feb 11, 2025
Contributor
peterwht
left a comment
peterwht
left a comment
There was a problem hiding this comment.
Looks good! Nice fix.
If you have the time, might be easy enough to add a failing test that is 15.1 MB to trigger the error. Not a blocker though
Collaborator
Author
Thanks, it make sense to have that test. Added in the commit 7d79720 |
peterwht
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to register a parachain using the wallet to sign the transaction, an error appeared in the frontend:
This was caused by the request body limit being too low, resulting in a
413 (Payload Too Large)error.This PR increases DefaultBodyLimit to handle larger payloads and adds a test to verify large transaction support. The 15MB limit is a bit arbitrary but ensures stability, providing enough room for 5MB transactions while accounting for potential encoding overhead.
Resource: https://stackoverflow.com/questions/75205271/rust-axum-multipart-length-limit-exceeded.