feat: register parachain #404

AlexD10S · 2025-02-09T11:17:52Z

This PR updates pop-cli to support one-command, production-ready parachain deployments.

Implement logic in the pop up to reserve the paraID, generate specifications, and register the parachain. feat: logic for parachain registration #410
Parse event to retrieve para ID when reserving it. feat: logic for parachain registration #410
Improve wallet signing UI to display the wallet balance and the deposit required for reserve and registration. feat: display costs for registration pop-wallet-signing-portal#7
Ensure a deterministic build for the release. feat: build deterministic runtime #425
Utilize a proxy for the registration. feat: use a proxy for the registration #427

How to test it
Start the Paseo parachain locally by running:

pop up parachain -f ./tests/networks/paseo.toml

Run pop up in your parachain folder or specify the folder with the path flag

pop up --path ../test-chain --relay-chain-url ws://127.0.0.1:49155

For more information run:

pop up --help

codecov · 2025-02-09T11:33:10Z

Codecov Report

Attention: Patch coverage is 69.05941% with 250 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@16693b4). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/pop-cli/src/commands/up/rollup.rs	67.52%	45 Missing and 56 partials ⚠️
crates/pop-cli/src/commands/build/spec.rs	59.61%	51 Missing and 12 partials ⚠️
crates/pop-cli/src/commands/call/chain.rs	58.13%	12 Missing and 6 partials ⚠️
crates/pop-cli/src/common/wallet.rs	0.00%	17 Missing ⚠️
crates/pop-parachains/src/build/runtime.rs	87.87%	6 Missing and 10 partials ⚠️
crates/pop-parachains/src/call/mod.rs	69.44%	3 Missing and 8 partials ⚠️
crates/pop-cli/src/commands/up/mod.rs	76.47%	0 Missing and 8 partials ⚠️
crates/pop-cli/src/common/chain.rs	75.00%	0 Missing and 6 partials ⚠️
crates/pop-parachains/src/build/mod.rs	88.23%	0 Missing and 4 partials ⚠️
crates/pop-common/src/account_id.rs	81.25%	0 Missing and 3 partials ⚠️
... and 3 more

@@           Coverage Diff           @@
##             main     #404   +/-   ##
=======================================
  Coverage        ?   75.17%           
=======================================
  Files           ?       68           
  Lines           ?    14903           
  Branches        ?    14903           
=======================================
  Hits            ?    11203           
  Misses          ?     2242           
  Partials        ?     1458

Files with missing lines	Coverage Δ
crates/pop-cli/src/commands/call/contract.rs	`80.38% <ø> (ø)`
crates/pop-cli/src/commands/mod.rs	`25.00% <100.00%> (ø)`
crates/pop-common/src/lib.rs	`74.50% <ø> (ø)`
crates/pop-contracts/src/call.rs	`73.25% <ø> (ø)`
crates/pop-contracts/src/utils/mod.rs	`81.81% <ø> (ø)`
crates/pop-parachains/src/call/metadata/mod.rs	`93.11% <ø> (ø)`
crates/pop-cli/src/commands/up/contract.rs	`40.95% <0.00%> (ø)`
crates/pop-cli/src/commands/up/network.rs	`6.81% <0.00%> (ø)`
crates/pop-parachains/src/relay.rs	`82.60% <0.00%> (ø)`
crates/pop-common/src/account_id.rs	`81.25% <81.25%> (ø)`
... and 9 more

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

evilrobot-01

Comments only as still a draft. Suggestions around rollup are simply based on the fact that we have to start somewhere. I think any new code should use rollup. We can then create a separate PR to add aliases etc and then simply rebase this PR as/when.

Also surprised you are using strings over enums - that should be addressed imo.

A few other general observations:

Not sure we need network if we are specifying -f ? Counter argument is if we are using network then we dont need to specify -f, it could just be pop u n ./network.toml. Or if we rename -f to -n, then pop up -n ./network.toml
cargo run -- up --help shows a 'smart contract deployment options' section but nothing for rollups?
we could still have the subcommands (contract, rollup, network), just optional. These can just be command aliases that map into the existing functions for pop up. Help text could be taken from the subcommand when generating the main help for pop up. I cant say what the technical complexities might be tho.
pop up --path ../test-chain --relay-url ws://127.0.0.1:49155 in the readme doesnt work
readme should be updated to rollup

crates/pop-cli/src/commands/mod.rs

crates/pop-cli/src/commands/up/mod.rs

crates/pop-cli/src/commands/up/network.rs

AlexD10S · 2025-03-01T10:30:57Z

Not sure we need network if we are specifying -f ? Counter argument is if we are using network then we dont need to specify -f, it could just be pop u n ./network.toml. Or if we rename -f to -n, then pop up -n ./network.toml

In my opinion, this approach makes it much clearer for the user: pop up deploys the project, while the network subcommand is used specifically for launching a local network.

We follow the same pattern with pop build, it builds the project, and for more specific logic like building specs, we use the spec subcommand.
That said, I agree that the -f flag can be avoided.

* feat: deploy a parachain commands * feat: build specs in pop up * feat: logic to interact with a chain * feat: register parachain * refactor: clean code and improve docs * test: unit tests for pop up methods * refactor: small fixes with visibility and removing logs * feat: return events in submit_signed_extrinsic * feat: get para_id from event * test: fix detects_parachain_correctly * refactor: improve docs and code * test: fix change_working_directory_works * fix: clippy warnings * refactor: move submit_extrinsic_with_wallet in a common file * refactor: remove unnecesary code * refactor: UpChainCommand structure * test: adjust tests to refactored struct * refactor: renaming prepare_register_parachain_call_data and prepare_rerve_parachain_call_data * refactor: move events module * fix: submit_extrinsic_with_wallet under parachain feature * refactor: remove unnecesary code * test: increase coverage with reserve_parachain_id_fails_wrong_chain and resolve_genesis_files_fails_wrong_path * refactor: remove unnecesary clones * refactor: minor improvements * test: refactor tests and include comments * refactor: map errors in submit_extrinsic_with_wallet * test: fix prepare_register_parachain_call_data_works * refactor: move configure_chain into a common folder * refactor: function visibility * fix: error message and include test for it * refactor: build specs removing repetitive code * refactor: use prepare_extrinsic from Call module to prepare a call * docs: improve comments and messages * refactor: rename variables and structs * refactor: relay_chain_url * refactor: rename prepare_reserve_call_data and prepare_register_call_data * test: remove unnecesary test * refactor: remove events module * refactor: rename parachain to rollup * chore: improve succesful message * chore: change intro title to use rollup * docs: comments for Reserved event * refactor: improve readability with chain::configure * refactor: improve message and clean code

* test: detects_project_type_correctly * feat: parachain deployment in pop up * fix: parachain feature * docs: improve comments * feat: deploy a parachain commands * feat: build specs in pop up * feat: logic to interact with a chain * feat: register parachain * refactor: clean code and improve docs * test: unit tests for pop up methods * refactor: small fixes with visibility and removing logs * feat: return events in submit_signed_extrinsic * feat: get para_id from event * test: fix detects_parachain_correctly * refactor: improve docs and code * test: fix change_working_directory_works * fix: clippy warnings * refactor: move submit_extrinsic_with_wallet in a common file * refactor: remove unnecesary code * refactor: UpChainCommand structure * test: adjust tests to refactored struct * refactor: renaming prepare_register_parachain_call_data and prepare_rerve_parachain_call_data * refactor: move events module * fix: submit_extrinsic_with_wallet under parachain feature * refactor: remove unnecesary code * test: increase coverage with reserve_parachain_id_fails_wrong_chain and resolve_genesis_files_fails_wrong_path * refactor: remove unnecesary clones * refactor: minor improvements * test: refactor tests and include comments * refactor: map errors in submit_extrinsic_with_wallet * test: fix prepare_register_parachain_call_data_works * feat: container_engine to detect container to use * feat: generate_deterministic_runtime logic * feat: srtool logic * feat: build deterministic runtime in build spec command * feat: update_runtime_code * test: include tests for updateing code * refactor: clean unnecesary code * test: in container_engine * refactor: docker warning in container_engine * chore: improve screen messaging * refactor: use profile picked by the user * refactor: docs in ContainerEngine and clean prints * fix: generate_deterministic_runtime parameter * refactor: rename, improve messages and clean empty lines * feat: extract package name automatically from runtime dir * docs: change broken link * refactor: update srtool_lib crate and remove unnecesary code * docs: include srtool in Acknowledgements * refactor: remove unnecesary Error * test: detects_project_type_correctly * feat: parachain deployment in pop up * fix: parachain feature * docs: improve comments * feat: replace index.html with summary costs in ui (#430) * refactor: rename parachain to rollup * docs: improve deprecation message * refactor: rename parachain to rollup in up help * feat: deploy a parachain commands * feat: build specs in pop up * feat: logic to interact with a chain * feat: register parachain * refactor: clean code and improve docs * test: unit tests for pop up methods * refactor: small fixes with visibility and removing logs * feat: return events in submit_signed_extrinsic * feat: get para_id from event * test: fix detects_parachain_correctly * refactor: improve docs and code * test: fix change_working_directory_works * fix: clippy warnings * refactor: move submit_extrinsic_with_wallet in a common file * refactor: remove unnecesary code * refactor: UpChainCommand structure * test: adjust tests to refactored struct * refactor: renaming prepare_register_parachain_call_data and prepare_rerve_parachain_call_data * refactor: move events module * fix: submit_extrinsic_with_wallet under parachain feature * refactor: remove unnecesary code * test: increase coverage with reserve_parachain_id_fails_wrong_chain and resolve_genesis_files_fails_wrong_path * refactor: remove unnecesary clones * refactor: minor improvements * test: refactor tests and include comments * refactor: map errors in submit_extrinsic_with_wallet * test: fix prepare_register_parachain_call_data_works * refactor: move configure_chain into a common folder * refactor: function visibility * fix: error message and include test for it * refactor: build specs removing repetitive code * refactor: use prepare_extrinsic from Call module to prepare a call * docs: improve comments and messages * refactor: rename variables and structs * refactor: relay_chain_url * refactor: rename prepare_reserve_call_data and prepare_register_call_data * test: remove unnecesary test * refactor: remove events module * refactor: rename parachain to rollup * chore: improve succesful message * chore: change intro title to use rollup * docs: comments for Reserved event * chore: always prompt the user to build runtime deterministacally and improve message * docs: improve and add missing comments * refactor: clean code to prompt for the package and runtime dir * docs: improve warning message * refactor: rename variables and structs * fix: throw error message when build deterministic runtime fail * feat: include skip_deterministic_build flag to avoid prompting the user * docs: improve comments

* test: detects_project_type_correctly * feat: parachain deployment in pop up * fix: parachain feature * docs: improve comments * feat: deploy a parachain commands * feat: build specs in pop up * feat: logic to interact with a chain * feat: register parachain * refactor: clean code and improve docs * test: unit tests for pop up methods * refactor: small fixes with visibility and removing logs * feat: return events in submit_signed_extrinsic * feat: get para_id from event * test: fix detects_parachain_correctly * refactor: improve docs and code * test: fix change_working_directory_works * fix: clippy warnings * refactor: move submit_extrinsic_with_wallet in a common file * refactor: remove unnecesary code * refactor: UpChainCommand structure * test: adjust tests to refactored struct * refactor: renaming prepare_register_parachain_call_data and prepare_rerve_parachain_call_data * refactor: move events module * fix: submit_extrinsic_with_wallet under parachain feature * refactor: remove unnecesary code * test: increase coverage with reserve_parachain_id_fails_wrong_chain and resolve_genesis_files_fails_wrong_path * refactor: remove unnecesary clones * refactor: minor improvements * test: refactor tests and include comments * refactor: map errors in submit_extrinsic_with_wallet * test: fix prepare_register_parachain_call_data_works * refactor: move configure_chain into a common folder * refactor: function visibility * fix: error message and include test for it * feat: construct_proxy_extrinsic * feat: prompt for proxy address in the UI * docs: improve flag description and display command to be executed * docs: improve prompt to the user message for proxy * feat: replace index.html with costs for calls with proxy in ui * refactor: remove display command information (separate PR) * test: fix resolve_proxy_address_works * refactor: rename and more clear messages for the user to prompt proxied account * chore: update index.html with latest changes * test: fix format * test: detects_project_type_correctly * feat: parachain deployment in pop up * fix: parachain feature * docs: improve comments * feat: replace index.html with summary costs in ui (#430) * refactor: rename parachain to rollup * docs: improve deprecation message * refactor: rename parachain to rollup in up help * feat: deploy a parachain commands * feat: build specs in pop up * feat: logic to interact with a chain * feat: register parachain * refactor: clean code and improve docs * test: unit tests for pop up methods * refactor: small fixes with visibility and removing logs * feat: return events in submit_signed_extrinsic * feat: get para_id from event * test: fix detects_parachain_correctly * refactor: improve docs and code * test: fix change_working_directory_works * fix: clippy warnings * refactor: move submit_extrinsic_with_wallet in a common file * refactor: remove unnecesary code * refactor: UpChainCommand structure * test: adjust tests to refactored struct * refactor: renaming prepare_register_parachain_call_data and prepare_rerve_parachain_call_data * refactor: move events module * fix: submit_extrinsic_with_wallet under parachain feature * refactor: remove unnecesary code * test: increase coverage with reserve_parachain_id_fails_wrong_chain and resolve_genesis_files_fails_wrong_path * refactor: remove unnecesary clones * refactor: minor improvements * test: refactor tests and include comments * refactor: map errors in submit_extrinsic_with_wallet * test: fix prepare_register_parachain_call_data_works * refactor: move configure_chain into a common folder * refactor: function visibility * fix: error message and include test for it * refactor: build specs removing repetitive code * refactor: use prepare_extrinsic from Call module to prepare a call * docs: improve comments and messages * refactor: rename variables and structs * refactor: relay_chain_url * refactor: rename prepare_reserve_call_data and prepare_register_call_data * test: remove unnecesary test * refactor: remove events module * refactor: rename parachain to rollup * chore: improve succesful message * chore: change intro title to use rollup * docs: comments for Reserved event * refactor: clean code to avoid unnecesary clone * feat: wrap Id by default in the proxy address and improve comment * refactor: remove ProxyConfig and use Proxy * refactor: resolve_proxied_address * fix: change visibility for prompt_for_param * refactor: more clarity in code variables and comments * refactor: custom message to prompt for proxy address * refactor: support only Account Id type for proxied_address * test: remove unnecesary async in resolve_proxied_address_works

* chore: hide srtool logs * chore: include runtime file in the Generated files message

chungquantin

Amazing work, Alex! I tested all functionalities of this PR and it works well. Just one feedback that the experience with building deterministic runtime is not clear to the user. Even though there is a spinner, it's hard to see. I would recommend informing the user that the step might take around 10-15 minutes so they are aware of it.

✅ Reserve a parachain ID with pop up --path . --relay-chain-url ws://127.0.0.1:50295
✅ Deploy a parachain and can find the parathread on PJS

Events are printed beautifully!

crates/pop-cli/src/commands/mod.rs

crates/pop-cli/src/commands/up/mod.rs

crates/pop-cli/src/commands/up/rollup.rs

crates/pop-cli/src/common/chain.rs

chungquantin

Registered with proxy and build deterministic runtime works perfectly as well. One final question, if my runtime is built deterministically with same configurations before, will it build the runtime again? Because when I run the command again after the built finish, it still take around 10-15 minutes to build the runtime. Could we no reuse the built runtime binary?

AlexD10S · 2025-03-17T07:57:35Z

Registered with proxy and build deterministic runtime works perfectly as well. One final question, if my runtime is built deterministically with same configurations before, will it build the runtime again? Because when I run the command again after the built finish, it still take around 10-15 minutes to build the runtime. Could we no reuse the built runtime binary?

It needs to be rebuilt as there may be changes, similar to when we build the node. However, I believe the second run takes less time.

chungquantin · 2025-03-17T08:00:25Z

Registered with proxy and build deterministic runtime works perfectly as well. One final question, if my runtime is built deterministically with same configurations before, will it build the runtime again? Because when I run the command again after the built finish, it still take around 10-15 minutes to build the runtime. Could we no reuse the built runtime binary?

It needs to be rebuilt as there may be changes, similar to when we build the node. However, I believe the second run takes less time.

Can we add an option to ask user if they want to rebuild their runtime? Or we can follow similar approach to the benchmarking feature that if binary exists, we don't build it. User can build manually if needed.

AlexD10S · 2025-03-17T08:13:59Z

Registered with proxy and build deterministic runtime works perfectly as well. One final question, if my runtime is built deterministically with same configurations before, will it build the runtime again? Because when I run the command again after the built finish, it still take around 10-15 minutes to build the runtime. Could we no reuse the built runtime binary?

It needs to be rebuilt as there may be changes, similar to when we build the node. However, I believe the second run takes less time.

Can we add an option to ask user if they want to rebuild their runtime? Or we can follow similar approach to the benchmarking feature that if binary exists, we don't build it. User can build manually if needed.

Interesting. It doesn’t make sense to ask for it after prompting 'Would you like to build the runtime deterministically?'. However, it might be a good idea to detect if the chain spec file exists after the prompt 'Name or path for the plain chain spec file:' and then ask the user if they want to rebuild it. In #459 we implemented the logic to prevent unnecessary chain spec rebuilds.

* test: detects_project_type_correctly * feat: parachain deployment in pop up * fix: parachain feature * docs: improve comments * feat: replace index.html with summary costs in ui (#430) * refactor: rename parachain to rollup * docs: improve deprecation message * refactor: rename parachain to rollup in up help * feat: logic for parachain registration (#410) * feat: deploy a parachain commands * feat: build specs in pop up * feat: logic to interact with a chain * feat: register parachain * refactor: clean code and improve docs * test: unit tests for pop up methods * refactor: small fixes with visibility and removing logs * feat: return events in submit_signed_extrinsic * feat: get para_id from event * test: fix detects_parachain_correctly * refactor: improve docs and code * test: fix change_working_directory_works * fix: clippy warnings * refactor: move submit_extrinsic_with_wallet in a common file * refactor: remove unnecesary code * refactor: UpChainCommand structure * test: adjust tests to refactored struct * refactor: renaming prepare_register_parachain_call_data and prepare_rerve_parachain_call_data * refactor: move events module * fix: submit_extrinsic_with_wallet under parachain feature * refactor: remove unnecesary code * test: increase coverage with reserve_parachain_id_fails_wrong_chain and resolve_genesis_files_fails_wrong_path * refactor: remove unnecesary clones * refactor: minor improvements * test: refactor tests and include comments * refactor: map errors in submit_extrinsic_with_wallet * test: fix prepare_register_parachain_call_data_works * refactor: move configure_chain into a common folder * refactor: function visibility * fix: error message and include test for it * refactor: build specs removing repetitive code * refactor: use prepare_extrinsic from Call module to prepare a call * docs: improve comments and messages * refactor: rename variables and structs * refactor: relay_chain_url * refactor: rename prepare_reserve_call_data and prepare_register_call_data * test: remove unnecesary test * refactor: remove events module * refactor: rename parachain to rollup * chore: improve succesful message * chore: change intro title to use rollup * docs: comments for Reserved event * refactor: improve readability with chain::configure * refactor: improve message and clean code * feat: build deterministic runtime (#425) * test: detects_project_type_correctly * feat: parachain deployment in pop up * fix: parachain feature * docs: improve comments * feat: deploy a parachain commands * feat: build specs in pop up * feat: logic to interact with a chain * feat: register parachain * refactor: clean code and improve docs * test: unit tests for pop up methods * refactor: small fixes with visibility and removing logs * feat: return events in submit_signed_extrinsic * feat: get para_id from event * test: fix detects_parachain_correctly * refactor: improve docs and code * test: fix change_working_directory_works * fix: clippy warnings * refactor: move submit_extrinsic_with_wallet in a common file * refactor: remove unnecesary code * refactor: UpChainCommand structure * test: adjust tests to refactored struct * refactor: renaming prepare_register_parachain_call_data and prepare_rerve_parachain_call_data * refactor: move events module * fix: submit_extrinsic_with_wallet under parachain feature * refactor: remove unnecesary code * test: increase coverage with reserve_parachain_id_fails_wrong_chain and resolve_genesis_files_fails_wrong_path * refactor: remove unnecesary clones * refactor: minor improvements * test: refactor tests and include comments * refactor: map errors in submit_extrinsic_with_wallet * test: fix prepare_register_parachain_call_data_works * feat: container_engine to detect container to use * feat: generate_deterministic_runtime logic * feat: srtool logic * feat: build deterministic runtime in build spec command * feat: update_runtime_code * test: include tests for updateing code * refactor: clean unnecesary code * test: in container_engine * refactor: docker warning in container_engine * chore: improve screen messaging * refactor: use profile picked by the user * refactor: docs in ContainerEngine and clean prints * fix: generate_deterministic_runtime parameter * refactor: rename, improve messages and clean empty lines * feat: extract package name automatically from runtime dir * docs: change broken link * refactor: update srtool_lib crate and remove unnecesary code * docs: include srtool in Acknowledgements * refactor: remove unnecesary Error * test: detects_project_type_correctly * feat: parachain deployment in pop up * fix: parachain feature * docs: improve comments * feat: replace index.html with summary costs in ui (#430) * refactor: rename parachain to rollup * docs: improve deprecation message * refactor: rename parachain to rollup in up help * feat: deploy a parachain commands * feat: build specs in pop up * feat: logic to interact with a chain * feat: register parachain * refactor: clean code and improve docs * test: unit tests for pop up methods * refactor: small fixes with visibility and removing logs * feat: return events in submit_signed_extrinsic * feat: get para_id from event * test: fix detects_parachain_correctly * refactor: improve docs and code * test: fix change_working_directory_works * fix: clippy warnings * refactor: move submit_extrinsic_with_wallet in a common file * refactor: remove unnecesary code * refactor: UpChainCommand structure * test: adjust tests to refactored struct * refactor: renaming prepare_register_parachain_call_data and prepare_rerve_parachain_call_data * refactor: move events module * fix: submit_extrinsic_with_wallet under parachain feature * refactor: remove unnecesary code * test: increase coverage with reserve_parachain_id_fails_wrong_chain and resolve_genesis_files_fails_wrong_path * refactor: remove unnecesary clones * refactor: minor improvements * test: refactor tests and include comments * refactor: map errors in submit_extrinsic_with_wallet * test: fix prepare_register_parachain_call_data_works * refactor: move configure_chain into a common folder * refactor: function visibility * fix: error message and include test for it * refactor: build specs removing repetitive code * refactor: use prepare_extrinsic from Call module to prepare a call * docs: improve comments and messages * refactor: rename variables and structs * refactor: relay_chain_url * refactor: rename prepare_reserve_call_data and prepare_register_call_data * test: remove unnecesary test * refactor: remove events module * refactor: rename parachain to rollup * chore: improve succesful message * chore: change intro title to use rollup * docs: comments for Reserved event * chore: always prompt the user to build runtime deterministacally and improve message * docs: improve and add missing comments * refactor: clean code to prompt for the package and runtime dir * docs: improve warning message * refactor: rename variables and structs * fix: throw error message when build deterministic runtime fail * feat: include skip_deterministic_build flag to avoid prompting the user * docs: improve comments * feat: use a proxy for the registration (#427) * test: detects_project_type_correctly * feat: parachain deployment in pop up * fix: parachain feature * docs: improve comments * feat: deploy a parachain commands * feat: build specs in pop up * feat: logic to interact with a chain * feat: register parachain * refactor: clean code and improve docs * test: unit tests for pop up methods * refactor: small fixes with visibility and removing logs * feat: return events in submit_signed_extrinsic * feat: get para_id from event * test: fix detects_parachain_correctly * refactor: improve docs and code * test: fix change_working_directory_works * fix: clippy warnings * refactor: move submit_extrinsic_with_wallet in a common file * refactor: remove unnecesary code * refactor: UpChainCommand structure * test: adjust tests to refactored struct * refactor: renaming prepare_register_parachain_call_data and prepare_rerve_parachain_call_data * refactor: move events module * fix: submit_extrinsic_with_wallet under parachain feature * refactor: remove unnecesary code * test: increase coverage with reserve_parachain_id_fails_wrong_chain and resolve_genesis_files_fails_wrong_path * refactor: remove unnecesary clones * refactor: minor improvements * test: refactor tests and include comments * refactor: map errors in submit_extrinsic_with_wallet * test: fix prepare_register_parachain_call_data_works * refactor: move configure_chain into a common folder * refactor: function visibility * fix: error message and include test for it * feat: construct_proxy_extrinsic * feat: prompt for proxy address in the UI * docs: improve flag description and display command to be executed * docs: improve prompt to the user message for proxy * feat: replace index.html with costs for calls with proxy in ui * refactor: remove display command information (separate PR) * test: fix resolve_proxy_address_works * refactor: rename and more clear messages for the user to prompt proxied account * chore: update index.html with latest changes * test: fix format * test: detects_project_type_correctly * feat: parachain deployment in pop up * fix: parachain feature * docs: improve comments * feat: replace index.html with summary costs in ui (#430) * refactor: rename parachain to rollup * docs: improve deprecation message * refactor: rename parachain to rollup in up help * feat: deploy a parachain commands * feat: build specs in pop up * feat: logic to interact with a chain * feat: register parachain * refactor: clean code and improve docs * test: unit tests for pop up methods * refactor: small fixes with visibility and removing logs * feat: return events in submit_signed_extrinsic * feat: get para_id from event * test: fix detects_parachain_correctly * refactor: improve docs and code * test: fix change_working_directory_works * fix: clippy warnings * refactor: move submit_extrinsic_with_wallet in a common file * refactor: remove unnecesary code * refactor: UpChainCommand structure * test: adjust tests to refactored struct * refactor: renaming prepare_register_parachain_call_data and prepare_rerve_parachain_call_data * refactor: move events module * fix: submit_extrinsic_with_wallet under parachain feature * refactor: remove unnecesary code * test: increase coverage with reserve_parachain_id_fails_wrong_chain and resolve_genesis_files_fails_wrong_path * refactor: remove unnecesary clones * refactor: minor improvements * test: refactor tests and include comments * refactor: map errors in submit_extrinsic_with_wallet * test: fix prepare_register_parachain_call_data_works * refactor: move configure_chain into a common folder * refactor: function visibility * fix: error message and include test for it * refactor: build specs removing repetitive code * refactor: use prepare_extrinsic from Call module to prepare a call * docs: improve comments and messages * refactor: rename variables and structs * refactor: relay_chain_url * refactor: rename prepare_reserve_call_data and prepare_register_call_data * test: remove unnecesary test * refactor: remove events module * refactor: rename parachain to rollup * chore: improve succesful message * chore: change intro title to use rollup * docs: comments for Reserved event * refactor: clean code to avoid unnecesary clone * feat: wrap Id by default in the proxy address and improve comment * refactor: remove ProxyConfig and use Proxy * refactor: resolve_proxied_address * fix: change visibility for prompt_for_param * refactor: more clarity in code variables and comments * refactor: custom message to prompt for proxy address * refactor: support only Account Id type for proxied_address * test: remove unnecesary async in resolve_proxied_address_works * fix: clippy warnings * chore: improve deterministic runtime flow (#460) * chore: hide srtool logs * chore: include runtime file in the Generated files message * chore: update with latest index.html * refactor: small improvements * refactor: improve the building runtime message

* refactor: check binary and prompt * feat: add binary generator * feat: update parachain templates (#297) * feat: include new parachain template and remove old one for Parity * fix: tests * fix: order in test * fix: export PATH * chore: bump zombienet-sdk version * fix: remove parity evm * fix: missing changes * fix: parse collator and parachain-template-node without path for spawn * chore: remove set PATH * refactor: functionality and test * refactor: prefix for external templates * fix: deprecate old command for generating parity contracts template * test: update configure_works test to test new functionality * test: fix unit tests templates * fix: show deprecation message and fixes * docs: improve comments * refactor: nitpicks in parachain description * fix: logic for substrate-contracts-node without path in config file * feat: support v3.0.0 of OpenZeppelin templates * docs: improve template docs and comments * test: improve comments for clarity * fix: support different profiles when path is not specified * refactor: code improvements * refactor: improve import * fix: remove onboard.rs empty file (#433) * chore: update cargo-deny-action@v2 (#439) * chore: update cargo-deny-action@v2 * chore: revert cargo.lock and add more ignore * fix: docker missing toolchain * chore: revert relay.rs changes * chore: remove vulnerabilities by upgrade zombienet * fix: hardcoded test failing in the CI (#448) * fix: remove hardcoded node name in test * fix: bump versions in Cargo.lock to fix deny * chore: ignore unmantained vulnerability * fix: cargo deny unmaintained crate --------- Co-authored-by: chungquantin <[email protected]> * feat: add the filter mode and password to `Cli` (#435) * feat: add the filter mode to cli * chore: rebase * chore: revert cargo.lock and add more ignore * chore: update cargo-deny-action@v2 * chore: revert relay.rs changes * chore: remove vulnerabilities by upgrade zombienet * chore: rebase * chore: clippy warning * chore: revert not relevant changes * chore: add password to the Cli (#449) * chore: add password input in cli module * chore: format --------- Co-authored-by: Alex Bean <[email protected]> * chore: resolve unmaintained crate & clippy warnings (#454) * chore: resolve clippy warnings * fix: unmantained crate * chore: hard-coded the version of pop-node binary * chore: fix pop-node CI issue * feat: register parachain (#404) * test: detects_project_type_correctly * feat: parachain deployment in pop up * fix: parachain feature * docs: improve comments * feat: replace index.html with summary costs in ui (#430) * refactor: rename parachain to rollup * docs: improve deprecation message * refactor: rename parachain to rollup in up help * feat: logic for parachain registration (#410) * feat: deploy a parachain commands * feat: build specs in pop up * feat: logic to interact with a chain * feat: register parachain * refactor: clean code and improve docs * test: unit tests for pop up methods * refactor: small fixes with visibility and removing logs * feat: return events in submit_signed_extrinsic * feat: get para_id from event * test: fix detects_parachain_correctly * refactor: improve docs and code * test: fix change_working_directory_works * fix: clippy warnings * refactor: move submit_extrinsic_with_wallet in a common file * refactor: remove unnecesary code * refactor: UpChainCommand structure * test: adjust tests to refactored struct * refactor: renaming prepare_register_parachain_call_data and prepare_rerve_parachain_call_data * refactor: move events module * fix: submit_extrinsic_with_wallet under parachain feature * refactor: remove unnecesary code * test: increase coverage with reserve_parachain_id_fails_wrong_chain and resolve_genesis_files_fails_wrong_path * refactor: remove unnecesary clones * refactor: minor improvements * test: refactor tests and include comments * refactor: map errors in submit_extrinsic_with_wallet * test: fix prepare_register_parachain_call_data_works * refactor: move configure_chain into a common folder * refactor: function visibility * fix: error message and include test for it * refactor: build specs removing repetitive code * refactor: use prepare_extrinsic from Call module to prepare a call * docs: improve comments and messages * refactor: rename variables and structs * refactor: relay_chain_url * refactor: rename prepare_reserve_call_data and prepare_register_call_data * test: remove unnecesary test * refactor: remove events module * refactor: rename parachain to rollup * chore: improve succesful message * chore: change intro title to use rollup * docs: comments for Reserved event * refactor: improve readability with chain::configure * refactor: improve message and clean code * feat: build deterministic runtime (#425) * test: detects_project_type_correctly * feat: parachain deployment in pop up * fix: parachain feature * docs: improve comments * feat: deploy a parachain commands * feat: build specs in pop up * feat: logic to interact with a chain * feat: register parachain * refactor: clean code and improve docs * test: unit tests for pop up methods * refactor: small fixes with visibility and removing logs * feat: return events in submit_signed_extrinsic * feat: get para_id from event * test: fix detects_parachain_correctly * refactor: improve docs and code * test: fix change_working_directory_works * fix: clippy warnings * refactor: move submit_extrinsic_with_wallet in a common file * refactor: remove unnecesary code * refactor: UpChainCommand structure * test: adjust tests to refactored struct * refactor: renaming prepare_register_parachain_call_data and prepare_rerve_parachain_call_data * refactor: move events module * fix: submit_extrinsic_with_wallet under parachain feature * refactor: remove unnecesary code * test: increase coverage with reserve_parachain_id_fails_wrong_chain and resolve_genesis_files_fails_wrong_path * refactor: remove unnecesary clones * refactor: minor improvements * test: refactor tests and include comments * refactor: map errors in submit_extrinsic_with_wallet * test: fix prepare_register_parachain_call_data_works * feat: container_engine to detect container to use * feat: generate_deterministic_runtime logic * feat: srtool logic * feat: build deterministic runtime in build spec command * feat: update_runtime_code * test: include tests for updateing code * refactor: clean unnecesary code * test: in container_engine * refactor: docker warning in container_engine * chore: improve screen messaging * refactor: use profile picked by the user * refactor: docs in ContainerEngine and clean prints * fix: generate_deterministic_runtime parameter * refactor: rename, improve messages and clean empty lines * feat: extract package name automatically from runtime dir * docs: change broken link * refactor: update srtool_lib crate and remove unnecesary code * docs: include srtool in Acknowledgements * refactor: remove unnecesary Error * test: detects_project_type_correctly * feat: parachain deployment in pop up * fix: parachain feature * docs: improve comments * feat: replace index.html with summary costs in ui (#430) * refactor: rename parachain to rollup * docs: improve deprecation message * refactor: rename parachain to rollup in up help * feat: deploy a parachain commands * feat: build specs in pop up * feat: logic to interact with a chain * feat: register parachain * refactor: clean code and improve docs * test: unit tests for pop up methods * refactor: small fixes with visibility and removing logs * feat: return events in submit_signed_extrinsic * feat: get para_id from event * test: fix detects_parachain_correctly * refactor: improve docs and code * test: fix change_working_directory_works * fix: clippy warnings * refactor: move submit_extrinsic_with_wallet in a common file * refactor: remove unnecesary code * refactor: UpChainCommand structure * test: adjust tests to refactored struct * refactor: renaming prepare_register_parachain_call_data and prepare_rerve_parachain_call_data * refactor: move events module * fix: submit_extrinsic_with_wallet under parachain feature * refactor: remove unnecesary code * test: increase coverage with reserve_parachain_id_fails_wrong_chain and resolve_genesis_files_fails_wrong_path * refactor: remove unnecesary clones * refactor: minor improvements * test: refactor tests and include comments * refactor: map errors in submit_extrinsic_with_wallet * test: fix prepare_register_parachain_call_data_works * refactor: move configure_chain into a common folder * refactor: function visibility * fix: error message and include test for it * refactor: build specs removing repetitive code * refactor: use prepare_extrinsic from Call module to prepare a call * docs: improve comments and messages * refactor: rename variables and structs * refactor: relay_chain_url * refactor: rename prepare_reserve_call_data and prepare_register_call_data * test: remove unnecesary test * refactor: remove events module * refactor: rename parachain to rollup * chore: improve succesful message * chore: change intro title to use rollup * docs: comments for Reserved event * chore: always prompt the user to build runtime deterministacally and improve message * docs: improve and add missing comments * refactor: clean code to prompt for the package and runtime dir * docs: improve warning message * refactor: rename variables and structs * fix: throw error message when build deterministic runtime fail * feat: include skip_deterministic_build flag to avoid prompting the user * docs: improve comments * feat: use a proxy for the registration (#427) * test: detects_project_type_correctly * feat: parachain deployment in pop up * fix: parachain feature * docs: improve comments * feat: deploy a parachain commands * feat: build specs in pop up * feat: logic to interact with a chain * feat: register parachain * refactor: clean code and improve docs * test: unit tests for pop up methods * refactor: small fixes with visibility and removing logs * feat: return events in submit_signed_extrinsic * feat: get para_id from event * test: fix detects_parachain_correctly * refactor: improve docs and code * test: fix change_working_directory_works * fix: clippy warnings * refactor: move submit_extrinsic_with_wallet in a common file * refactor: remove unnecesary code * refactor: UpChainCommand structure * test: adjust tests to refactored struct * refactor: renaming prepare_register_parachain_call_data and prepare_rerve_parachain_call_data * refactor: move events module * fix: submit_extrinsic_with_wallet under parachain feature * refactor: remove unnecesary code * test: increase coverage with reserve_parachain_id_fails_wrong_chain and resolve_genesis_files_fails_wrong_path * refactor: remove unnecesary clones * refactor: minor improvements * test: refactor tests and include comments * refactor: map errors in submit_extrinsic_with_wallet * test: fix prepare_register_parachain_call_data_works * refactor: move configure_chain into a common folder * refactor: function visibility * fix: error message and include test for it * feat: construct_proxy_extrinsic * feat: prompt for proxy address in the UI * docs: improve flag description and display command to be executed * docs: improve prompt to the user message for proxy * feat: replace index.html with costs for calls with proxy in ui * refactor: remove display command information (separate PR) * test: fix resolve_proxy_address_works * refactor: rename and more clear messages for the user to prompt proxied account * chore: update index.html with latest changes * test: fix format * test: detects_project_type_correctly * feat: parachain deployment in pop up * fix: parachain feature * docs: improve comments * feat: replace index.html with summary costs in ui (#430) * refactor: rename parachain to rollup * docs: improve deprecation message * refactor: rename parachain to rollup in up help * feat: deploy a parachain commands * feat: build specs in pop up * feat: logic to interact with a chain * feat: register parachain * refactor: clean code and improve docs * test: unit tests for pop up methods * refactor: small fixes with visibility and removing logs * feat: return events in submit_signed_extrinsic * feat: get para_id from event * test: fix detects_parachain_correctly * refactor: improve docs and code * test: fix change_working_directory_works * fix: clippy warnings * refactor: move submit_extrinsic_with_wallet in a common file * refactor: remove unnecesary code * refactor: UpChainCommand structure * test: adjust tests to refactored struct * refactor: renaming prepare_register_parachain_call_data and prepare_rerve_parachain_call_data * refactor: move events module * fix: submit_extrinsic_with_wallet under parachain feature * refactor: remove unnecesary code * test: increase coverage with reserve_parachain_id_fails_wrong_chain and resolve_genesis_files_fails_wrong_path * refactor: remove unnecesary clones * refactor: minor improvements * test: refactor tests and include comments * refactor: map errors in submit_extrinsic_with_wallet * test: fix prepare_register_parachain_call_data_works * refactor: move configure_chain into a common folder * refactor: function visibility * fix: error message and include test for it * refactor: build specs removing repetitive code * refactor: use prepare_extrinsic from Call module to prepare a call * docs: improve comments and messages * refactor: rename variables and structs * refactor: relay_chain_url * refactor: rename prepare_reserve_call_data and prepare_register_call_data * test: remove unnecesary test * refactor: remove events module * refactor: rename parachain to rollup * chore: improve succesful message * chore: change intro title to use rollup * docs: comments for Reserved event * refactor: clean code to avoid unnecesary clone * feat: wrap Id by default in the proxy address and improve comment * refactor: remove ProxyConfig and use Proxy * refactor: resolve_proxied_address * fix: change visibility for prompt_for_param * refactor: more clarity in code variables and comments * refactor: custom message to prompt for proxy address * refactor: support only Account Id type for proxied_address * test: remove unnecesary async in resolve_proxied_address_works * fix: clippy warnings * chore: improve deterministic runtime flow (#460) * chore: hide srtool logs * chore: include runtime file in the Generated files message * chore: update with latest index.html * refactor: small improvements * refactor: improve the building runtime message * fix: display events when wallet-signing (#463) * feat: enable `pop test` without project type specification (#466) * refactor: test_project to support testing any rust project * test: unit tests in test mod * docs: fix pop_contracts test docs * docs: fix comment in TestCommand error * refactor: improve docs and visibility * chore: add doc for macro and test for contracts * fix: executable permission --------- Co-authored-by: Alex Bean <[email protected]>

AlexD10S mentioned this pull request Feb 9, 2025

feat: enable pop up without project type specification #403

Merged

AlexD10S force-pushed the feat/deploy-parachain branch from 511e547 to 945a8ac Compare February 14, 2025 12:22

AlexD10S mentioned this pull request Feb 15, 2025

feat: logic for parachain registration #410

Merged

Base automatically changed from refactor/pop-up to main February 17, 2025 12:08

AlexD10S force-pushed the feat/deploy-parachain branch 2 times, most recently from df55096 to 0a64db8 Compare February 17, 2025 16:34

This was referenced Feb 24, 2025

feat: build deterministic runtime #425

Merged

feat: use a proxy for the registration #427

Merged

evilrobot-01 reviewed Feb 28, 2025

View reviewed changes

AlexD10S force-pushed the feat/deploy-parachain branch 2 times, most recently from 4f594c4 to 75896e8 Compare March 5, 2025 21:47

AlexD10S force-pushed the feat/deploy-parachain branch from 13bb837 to 3542b59 Compare March 10, 2025 10:14

AlexD10S marked this pull request as ready for review March 10, 2025 11:45

AlexD10S added 12 commits March 11, 2025 16:03

test: detects_project_type_correctly

00cc2f0

feat: parachain deployment in pop up

f6664c1

fix: parachain feature

5909801

docs: improve comments

064a146

feat: replace index.html with summary costs in ui (#430)

ca32416

refactor: rename parachain to rollup

a50291d

docs: improve deprecation message

4247cf7

refactor: rename parachain to rollup in up help

f309f81

fix: clippy warnings

556b053

AlexD10S force-pushed the feat/deploy-parachain branch from d497a63 to 556b053 Compare March 11, 2025 15:04

chore: improve deterministic runtime flow (#460)

5a6c29c

* chore: hide srtool logs * chore: include runtime file in the Generated files message

AlexD10S requested a review from chungquantin March 13, 2025 08:54

AlexD10S mentioned this pull request Mar 13, 2025

feat: integration with deployment provider #459

Merged

chore: update with latest index.html

1602a33

chungquantin approved these changes Mar 14, 2025

View reviewed changes

refactor: small improvements

3d5a415

AlexD10S requested a review from chungquantin March 15, 2025 16:50

refactor: improve the building runtime message

a6579b8

chungquantin approved these changes Mar 17, 2025

View reviewed changes

AlexD10S changed the title ~~feat: deploy parachain~~ feat: register parachain Mar 17, 2025

AlexD10S merged commit ac20cd3 into main Mar 17, 2025
20 checks passed

AlexD10S deleted the feat/deploy-parachain branch March 17, 2025 10:40

feat: register parachain #404

feat: register parachain #404

Uh oh!

Conversation

AlexD10S commented Feb 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Feb 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

evilrobot-01 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AlexD10S commented Mar 1, 2025

Uh oh!

chungquantin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chungquantin left a comment

Choose a reason for hiding this comment

Uh oh!

AlexD10S commented Mar 17, 2025

Uh oh!

chungquantin commented Mar 17, 2025

Uh oh!

AlexD10S commented Mar 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

AlexD10S commented Feb 9, 2025 •

edited

Loading

codecov bot commented Feb 9, 2025 •

edited

Loading