fix: check_contracts_node handles skip_confirm #396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
al3mart
added
bug
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #396 +/- ##
==========================================
+ Coverage 75.15% 75.17% +0.01%
==========================================
Files 62 62
Lines 13820 13835 +15
Branches 13820 13835 +15
==========================================
+ Hits 10386 10400 +14
Misses 2082 2082
- Partials 1352 1353 +1
|
AlexD10S
approved these changes
Jan 3, 2025
Collaborator
AlexD10S
left a comment
AlexD10S
left a comment
There was a problem hiding this comment.
LGTM! Thanks for fixing this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a small bug where the
skip_confirmwas ignored.Prompting the user to source
sustrate-contracts-node.I have added a very minimal test. It could be improved and made more robust if we were to expand
MockClito include checks for certain prompts not being presented in the CLI. But that is another story.Thanks to @ltfschoen for reporting.
[sc-2094]