Skip to content

chore: release v0.6.0 #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AlexD10S merged 11 commits into from
Dec 19, 2024
Merged

chore: release v0.6.0 #394

AlexD10S merged 11 commits into from
Dec 19, 2024

Conversation

@AlexD10S
Copy link
Collaborator

@AlexD10S AlexD10S commented Dec 19, 2024

  • Update crate versions to 0.6.0.
  • Update Changelog file. Run git cliff --bump, but fixed manually.
  • Remove Deprecated flags or commands:
    - Remove the subcommands parachain and contract in pop build.
    - Old feature to run e2e tests..
    - OpenZeppelin template name changed.
    Note: In this release, a new deprecated flag has been introduced. The release flag is being deprecated in favor of profile (see source).
    Note 2: Parity templates will be addressed in feat: update parachain templates #297

@codecov
Copy link

codecov bot commented Dec 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 67.74194% with 10 lines in your changes missing coverage. Please review.

Project coverage is 75.15%. Comparing base (661c625) to head (eac11e4).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/pop-cli/src/commands/build/mod.rs 0.00% 4 Missing ⚠️
crates/pop-cli/src/commands/build/parachain.rs 80.00% 0 Missing and 4 partials ⚠️
crates/pop-cli/src/commands/build/contract.rs 66.66% 0 Missing and 2 partials ⚠️ 
@@            Coverage Diff             @@
##             main     #394      +/-   ##
==========================================
+ Coverage   75.10%   75.15%   +0.05%     
==========================================
  Files          62       62              
  Lines       13860    13820      -40     
  Branches    13860    13820      -40     
==========================================
- Hits        10409    10386      -23     
+ Misses       2094     2082      -12     
+ Partials     1357     1352       -5
Files with missing lines Coverage Δ
crates/pop-cli/src/commands/mod.rs 16.32% <ø> (+0.32%) ⬆️
crates/pop-cli/src/commands/test/contract.rs 0.00% <ø> (ø)
crates/pop-parachains/src/new_parachain.rs 79.80% <100.00%> (+2.23%) ⬆️
crates/pop-parachains/src/templates.rs 98.63% <ø> (-0.03%) ⬇️
crates/pop-cli/src/commands/build/contract.rs 53.84% <66.66%> (-7.27%) ⬇️
crates/pop-cli/src/commands/build/mod.rs 50.63% <0.00%> (+0.63%) ⬆️
crates/pop-cli/src/commands/build/parachain.rs 72.22% <80.00%> (-1.28%) ⬇️

... and 1 file with indirect coverage changes

Daanvdplas
Daanvdplas reviewed Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@Daanvdplas Daanvdplas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was only able to provide input for the removal of the BuildParachainCmd and BuildContractCmd as I was not involved with the other deprecations.

@AlexD10S AlexD10S force-pushed the chore/release-v0.6.0 branch from 95b6a61 to 9724dd6 Compare December 19, 2024 13:22
@AlexD10S AlexD10S marked this pull request as ready for review December 19, 2024 13:22
Daanvdplas
Daanvdplas reviewed Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@Daanvdplas Daanvdplas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the two Build_Cmd types can be refactored a little bit more

Daanvdplas
Daanvdplas reviewed Dec 19, 2024
View reviewed changes
@AlexD10S AlexD10S requested a review from Daanvdplas December 19, 2024 16:15
Daanvdplas
Daanvdplas approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@Daanvdplas Daanvdplas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from some final nitpicks looking good!

Note: I am not so familar with the openzeppelin and e2e tests so this should be reviewed by someone who is

@AlexD10S AlexD10S requested a review from al3mart December 19, 2024 16:46
@AlexD10S
Copy link
Collaborator Author

AlexD10S commented Dec 19, 2024

Note: I am not so familar with the openzeppelin and e2e tests so this should be reviewed by someone who is

Thanks!
The tricky part was removing the deprecated code from the build. e2e tests and OZ old naming template is a very straightforward removal. Anyway, I’ve requested another review just to be sure.

@AlexD10S AlexD10S merged commit cbf722a into main Dec 19, 2024
19 of 20 checks passed
@AlexD10S AlexD10S deleted the chore/release-v0.6.0 branch December 19, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Daanvdplas Daanvdplas Daanvdplas approved these changes

@peterwht peterwht peterwht approved these changes

@evilrobot-01 evilrobot-01 Awaiting requested review from evilrobot-01

@al3mart al3mart Awaiting requested review from al3mart

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AlexD10S @peterwht @Daanvdplas