fix: templates errors #329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #329 +/- ##
==========================================
+ Coverage 70.33% 70.38% +0.04%
==========================================
Files 53 53
Lines 9098 9123 +25
Branches 9098 9123 +25
==========================================
+ Hits 6399 6421 +22
Misses 1718 1718
- Partials 981 984 +3
|
brunopgalvao
approved these changes
Oct 31, 2024
evilrobot-01
reviewed
Nov 4, 2024
Contributor
evilrobot-01
left a comment
evilrobot-01
left a comment
There was a problem hiding this comment.
Just one question which might be worth addressing - whether we should wrap the contract name in string delimiters to more precisely target the update.
The rest are purely observational and dont need addressing now.
evilrobot-01
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #323. For the contract_template's
cross-contract-calls, it was necessary to renamee2e_tests.rsto match the user-defined input name. Without this adjustment, the e2e tests would fail due to the file not being correctly recognized.Closes #321 using the PSP34 managed by R0gue: https://github.com/r0gue-io/PSP34