fix: fetch stable version #328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evilrobot-01
suggested changes
Nov 5, 2024
Contributor
evilrobot-01
left a comment
evilrobot-01
left a comment
There was a problem hiding this comment.
Looks good apart from the use of 'helpers'. Its highly subjective, but my view is that using 'helpers' does nothing for discoverability of code and therefore fails in terms of devex for the crate consumer. Modules can be descriptive and expressive.
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #328 +/- ##
==========================================
+ Coverage 70.33% 70.35% +0.02%
==========================================
Files 53 54 +1
Lines 9098 9105 +7
Branches 9098 9105 +7
==========================================
+ Hits 6399 6406 +7
Misses 1718 1718
Partials 981 981
|
al3mart
approved these changes
Nov 6, 2024
Member
al3mart
left a comment
al3mart
left a comment
There was a problem hiding this comment.
Couldn't point out anything. Nice one!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the sorting issue identified in: #325 where versioned tags were prioritized over
stable2409in thepop up parachainprocess.Changes