feat: integration openzeppelin evm template #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #284 +/- ##
==========================================
+ Coverage 70.32% 70.61% +0.28%
==========================================
Files 53 54 +1
Lines 9098 9228 +130
Branches 9098 9228 +130
==========================================
+ Hits 6398 6516 +118
- Misses 1718 1719 +1
- Partials 982 993 +11
|
Contributor
|
Thanks for that! Looking great to me as well |
pepoviola
reviewed
Sep 12, 2024
Contributor
evilrobot-01
left a comment
evilrobot-01
left a comment
There was a problem hiding this comment.
A quick review, a few minor comments.
al3mart
reviewed
Nov 4, 2024
Member
al3mart
left a comment
al3mart
left a comment
There was a problem hiding this comment.
Looks good, just left a small nit :)
al3mart
approved these changes
Nov 5, 2024
evilrobot-01
approved these changes
Nov 6, 2024
evilrobot-01
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to support OZ EVM template: https://github.com/OpenZeppelin/polkadot-runtime-templates/tree/main/evm-template
To support EVM chains in Zombienet, the config file includes
force_decorator = "generic-evm". When this field is present,popinjectsevm_based = trueto ensure compatibility with Zombienet-SDK after the recent fix: paritytech/zombienet-sdk#256