feat: enable building without project type specification #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #222 +/- ##
==========================================
+ Coverage 70.34% 70.40% +0.06%
==========================================
Files 44 46 +2
Lines 6787 7045 +258
Branches 6787 7045 +258
==========================================
+ Hits 4774 4960 +186
- Misses 1240 1258 +18
- Partials 773 827 +54
|
evilrobot-01
force-pushed
the
frank/build
branch
from
c30a4d8 to
855820c
Compare
added 5 commits
June 27, 2024 13:57
evilrobot-01
force-pushed
the
frank/build
branch
from
855820c to
20ee151
Compare
AlexD10S
reviewed
Jun 27, 2024
AlexD10S
reviewed
Jun 27, 2024
added 6 commits
July 3, 2024 11:19
As agreed separately with PO.
Simply attempts to build as a normal Rust project otherwise.
evilrobot-01
changed the title
AlexD10S
reviewed
Jul 3, 2024
Collaborator
There was a problem hiding this comment.
Great job. I just left a few small comments. This will have a lot of conflicts with: #219. If you finish the test, I am happy to merge this first and handle the conflicts myself.
There is no need to include it in this PR. But as a refactor we should remove the short = 'p' in the other commands to maintain consistency and avoid confusing the user.
#[arg(short = 'p', long)]
path: Option<PathBuf>,
And finally, this PR will close #91
# Conflicts: # crates/pop-contracts/src/errors.rs
AlexD10S
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables building without needing to specify the project type - i.e.
pop b -rTODO:
-pto support package specification, so it can act as a simple wrapper tocargo b -p