Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specifying line type in the webR Canvas graphics device does not work #289

Closed
bugzpodder opened this issue Oct 6, 2023 · 1 comment · Fixed by #301
Closed

Specifying line type in the webR Canvas graphics device does not work #289

bugzpodder opened this issue Oct 6, 2023 · 1 comment · Fixed by #301
Labels
bug Something isn't working

Comments

@bugzpodder
Copy link
Contributor

Not sure if its discrependency is intended but i am seeing a very slight difference in the following code in RStudio vs webR

library('ggplot2')
ggplot() +
    geom_hline(aes(yintercept = 10, linetype = "p-value Threshold"), color = "green") + 
    geom_vline(aes(xintercept = 1, linetype = "Upper FC"), color = "blue") + 
    geom_vline(aes(xintercept = -1, linetype = "Lower FC"), color = "red")

RStudio shows the lines as dashed and webR (using plot()) draws the line as solid.
Screenshot 2023-10-05 at 5 03 29 PM
@georgestagg
Copy link
Member

Thanks, this looks like a more general bug with line types in the Canvas graphics device!

For example, the code

plot(1:10, 1:10, type="l", lty=2)

should produce a dashed line, but instead produce a solid line.

@georgestagg georgestagg changed the title slight differences in plot with RStudio and WebR Specifying line type in the webR Canvas graphics device does not work Oct 6, 2023
@georgestagg georgestagg added the bug Something isn't working label Oct 6, 2023
georgestagg added a commit that referenced this issue Oct 17, 2023
@georgestagg
Fix the lty property in canvas graphics device
0b1d0dd 
Fixes #289
This was referenced Oct 17, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the lty property in canvas graphics device r-wasm/webr
2 participants
@georgestagg @bugzpodder